linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 4/4] regulator: map consumer regulator based on device tree
Date: Wed, 23 Nov 2011 18:44:17 +0000	[thread overview]
Message-ID: <20111123184416.GA17587@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1321615040-13257-5-git-send-email-rnayak@ti.com>

On Fri, Nov 18, 2011 at 04:47:20PM +0530, Rajendra Nayak wrote:

> +	struct device_node *regnode = NULL;
> +	char prop_name[32]; /* 32 is max size of property name */

There ought to be a #define for that though I can't see one right now -
this can't be the only place where we need to do stuff like this.

> +
> +	dev_dbg(dev, "Looking up %s-supply from device tree\n", supply);
> +
> +	snprintf(prop_name, 32, "%s-supply", supply);

sizeof().

  reply	other threads:[~2011-11-23 18:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-18 11:17 [PATCH v5 0/4] Device tree support for regulators Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 1/4] regulator: helper routine to extract regulator_init_data Rajendra Nayak
2011-12-04 13:21   ` Thomas Abraham
2011-12-04 15:54     ` Mark Brown
2011-12-05  9:10       ` Thomas Abraham
2011-12-05 10:34         ` Mark Brown
2011-12-05 10:44           ` Thomas Abraham
2011-12-05 10:57             ` Mark Brown
2011-12-05 11:09               ` Thomas Abraham
2011-12-06  6:54               ` Rajendra Nayak
2012-05-23 17:48   ` David Brown
2011-11-18 11:17 ` [PATCH v5 2/4] regulator: adapt fixed regulator driver to dt Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 3/4] regulator: pass additional of_node to regulator_register() Rajendra Nayak
2011-12-04  9:53   ` Thomas Abraham
2011-12-05  7:19     ` Rajendra Nayak
2011-11-18 11:17 ` [PATCH v5 4/4] regulator: map consumer regulator based on device tree Rajendra Nayak
2011-11-23 18:44   ` Mark Brown [this message]
2011-11-23 19:01 ` [PATCH v5 0/4] Device tree support for regulators Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111123184416.GA17587@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).