From: buytenh@wantstofly.org (Lennert Buytenhek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mach-orion5x: Use hex2bin that is present in kernel lib
Date: Thu, 24 Nov 2011 07:40:18 +0100 [thread overview]
Message-ID: <20111124064018.GD795@wantstofly.org> (raw)
In-Reply-To: <1322058417.2472.9.camel@localhost.localdomain>
On Wed, Nov 23, 2011 at 04:26:57PM +0200, plaes at plaes.org wrote:
> Hey!
Hello!
> I noticed there was some duplicate code under arm/mach-orion5x directory
> so I ended up with a patch that uses existing library function present
> in kernel code.
>
> I regretfully have to admit that this patch is NOT even compile-tested,
> but I hope that it still useful in case it happens to break something...
>
> [...]
>
> for (i = 0; i < 6; i++) {
> - int byte;
> -
> - byte = dns323_parse_hex_byte(mac_page + (i * 3));
> - if (byte < 0) {
> + if (hex2bin(addr[i], mac_page + (i * 3), 2))
> goto error_fail;
I don't think that this does what you think it does...
thanks,
Lennert
next prev parent reply other threads:[~2011-11-24 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 14:26 [PATCH] ARM: mach-orion5x: Use hex2bin that is present in kernel lib plaes at plaes.org
2011-11-24 6:40 ` Lennert Buytenhek [this message]
2011-11-24 9:49 ` plaes at plaes.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124064018.GD795@wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).