* [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs
@ 2011-11-30 11:31 Fabio Estevam
2011-11-30 13:25 ` Uwe Kleine-König
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabio Estevam @ 2011-11-30 11:31 UTC (permalink / raw)
To: linux-arm-kernel
Let the FEC driver be built by default.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
Move the FEC selection into Kconfig instead of .config file
drivers/net/ethernet/freescale/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index c520cfd..ae269ad 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -22,6 +22,7 @@ if NET_VENDOR_FREESCALE
config FEC
bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
+ default ARCH_MXC || ARCH_MXS if ARM
depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
ARCH_MXC || ARCH_MXS)
select PHYLIB
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs
2011-11-30 11:31 [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs Fabio Estevam
@ 2011-11-30 13:25 ` Uwe Kleine-König
2011-11-30 13:26 ` Uwe Kleine-König
2011-11-30 13:37 ` Shawn Guo
2011-11-30 14:42 ` [PATCH v3] " Fabio Estevam
2 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2011-11-30 13:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 30, 2011 at 09:31:57AM -0200, Fabio Estevam wrote:
> Let the FEC driver be built by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Just one small nitpick below. Other than that:
Suggested-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Changes since v1:
> Move the FEC selection into Kconfig instead of .config file
>
> drivers/net/ethernet/freescale/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index c520cfd..ae269ad 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -22,6 +22,7 @@ if NET_VENDOR_FREESCALE
>
> config FEC
> bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
> + default ARCH_MXC || ARCH_MXS if ARM
> depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
> ARCH_MXC || ARCH_MXS)
I'd write the depends line first, then default and then select.
Best regards
Uwe
> select PHYLIB
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs
2011-11-30 13:25 ` Uwe Kleine-König
@ 2011-11-30 13:26 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2011-11-30 13:26 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 30, 2011 at 02:25:36PM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Nov 30, 2011 at 09:31:57AM -0200, Fabio Estevam wrote:
> > Let the FEC driver be built by default.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Just one small nitpick below. Other than that:
>
> Suggested-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
ah, and maybe point out the breaking commit in the log.
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs
2011-11-30 11:31 [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs Fabio Estevam
2011-11-30 13:25 ` Uwe Kleine-König
@ 2011-11-30 13:37 ` Shawn Guo
2011-11-30 14:42 ` [PATCH v3] " Fabio Estevam
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2011-11-30 13:37 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 30, 2011 at 09:31:57AM -0200, Fabio Estevam wrote:
> Let the FEC driver be built by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Regards,
Shawn
> ---
> Changes since v1:
> Move the FEC selection into Kconfig instead of .config file
>
> drivers/net/ethernet/freescale/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
> index c520cfd..ae269ad 100644
> --- a/drivers/net/ethernet/freescale/Kconfig
> +++ b/drivers/net/ethernet/freescale/Kconfig
> @@ -22,6 +22,7 @@ if NET_VENDOR_FREESCALE
>
> config FEC
> bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
> + default ARCH_MXC || ARCH_MXS if ARM
> depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
> ARCH_MXC || ARCH_MXS)
> select PHYLIB
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3] net: fec: Select the FEC driver by default for i.MX SoCs
2011-11-30 11:31 [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs Fabio Estevam
2011-11-30 13:25 ` Uwe Kleine-König
2011-11-30 13:37 ` Shawn Guo
@ 2011-11-30 14:42 ` Fabio Estevam
2011-11-30 22:08 ` David Miller
2 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2011-11-30 14:42 UTC (permalink / raw)
To: linux-arm-kernel
Since commit 230dec6 (net/fec: add imx6q enet support) the FEC driver is no
longer built by default for i.MX SoCs.
Let the FEC driver be built by default again.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Suggested-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
Acked-by: Uwe Kleine-K??nig <u.kleine-koenig at pengutronix.de
Acked-by: Shawn Guo <shawn.guo@linaro.org>
---
Changes since v2:
- Improve commit message
- Reorder the placement of the "default" line
Changes since v1:
Move the FEC selection into Kconfig instead of .config file
drivers/net/ethernet/freescale/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/freescale/Kconfig b/drivers/net/ethernet/freescale/Kconfig
index c520cfd..5272f9d 100644
--- a/drivers/net/ethernet/freescale/Kconfig
+++ b/drivers/net/ethernet/freescale/Kconfig
@@ -24,6 +24,7 @@ config FEC
bool "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
ARCH_MXC || ARCH_MXS)
+ default ARCH_MXC || ARCH_MXS if ARM
select PHYLIB
---help---
Say Y here if you want to use the built-in 10/100 Fast ethernet
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v3] net: fec: Select the FEC driver by default for i.MX SoCs
2011-11-30 14:42 ` [PATCH v3] " Fabio Estevam
@ 2011-11-30 22:08 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2011-11-30 22:08 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@freescale.com>
Date: Wed, 30 Nov 2011 12:42:18 -0200
> Since commit 230dec6 (net/fec: add imx6q enet support) the FEC driver is no
> longer built by default for i.MX SoCs.
>
> Let the FEC driver be built by default again.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> Suggested-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
Applied.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-11-30 22:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-30 11:31 [PATCH v2] net: fec: Select the FEC driver by default for i.MX SoCs Fabio Estevam
2011-11-30 13:25 ` Uwe Kleine-König
2011-11-30 13:26 ` Uwe Kleine-König
2011-11-30 13:37 ` Shawn Guo
2011-11-30 14:42 ` [PATCH v3] " Fabio Estevam
2011-11-30 22:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).