linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 3/5] ARM: vexpress: Add DT support in v2m
Date: Wed, 30 Nov 2011 15:58:00 +0000	[thread overview]
Message-ID: <20111130155800.GF2045@localhost.localdomain> (raw)
In-Reply-To: <1322579473-8804-4-git-send-email-pawel.moll@arm.com>

On Tue, Nov 29, 2011 at 03:11:11PM +0000, Pawel Moll wrote:
> This patch provides hooks for DT-based tile machine implementations
> and adds Device Tree description for the motherboard.

[...]

> +config ARCH_VEXPRESS_DT
> +	bool
> +	select OF
> +	help
> +	  VE platform *requiring* Flattened Device Tree to boot.
> +

Now that a person may fail to boot on a supported board simply due to
failing to supply a device tree, it may be a good idea to have a more
helpful panic message for that situation, perhaps something like the
following.

If you don't think this fits in this series, I can always follow up 
later.

Cheers
---Dave


diff --git a/arch/arm/mach-vexpress/v2m.c b/arch/arm/mach-vexpress/v2m.c
index 6965f64..9dda482 100644
--- a/arch/arm/mach-vexpress/v2m.c
+++ b/arch/arm/mach-vexpress/v2m.c
@@ -434,8 +434,11 @@ static void __init v2m_populate_ct_desc(void)
 			ct_desc = ct_descs[i];
 
 	if (!ct_desc)
-		panic("vexpress: failed to populate core tile description "
-		      "for tile ID 0x%8x\n", current_tile_id);
+		panic("vexpress: this kernel does not support core tile ID "
+		      "0x%08x when booting via ATAGs.\n"
+		      "You may need a device tree blob or a different kernel "
+		      "to boot on this board.\n",
+		      current_tile_id);
 }
 
 static void __init v2m_map_io(void)

  parent reply	other threads:[~2011-11-30 15:58 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 15:11 [PATCH v3 0/5] Versatile Express DT support Pawel Moll
2011-11-29 15:11 ` [PATCH v3 1/5] ARM: versatile: Add missing ENDPROC to headsmp.S Pawel Moll
2011-11-29 15:11 ` [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V Pawel Moll
2011-11-29 21:15   ` Arnd Bergmann
2011-11-30 11:34     ` Pawel Moll
2011-11-30 13:48       ` Arnd Bergmann
2011-11-30 13:52         ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 3/5] ARM: vexpress: Add DT support in v2m Pawel Moll
2011-11-29 21:19   ` Arnd Bergmann
2011-11-30 11:46     ` Pawel Moll
2011-11-30 13:34       ` Arnd Bergmann
2011-11-30 13:38         ` Pawel Moll
2011-11-30 15:10           ` Arnd Bergmann
2011-11-30 15:58   ` Dave Martin [this message]
2011-11-30 18:46     ` Pawel Moll
2011-12-01 10:57       ` Dave Martin
2011-12-05 16:25   ` Dave Martin
2011-12-05 16:30     ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support Pawel Moll
2011-11-30 15:37   ` Dave Martin
2011-11-30 17:15     ` Pawel Moll
2011-11-30 17:54       ` Dave Martin
2011-11-30 18:31         ` Pawel Moll
2011-11-30 20:43         ` Nicolas Pitre
2011-11-30 20:48           ` Mark Brown
2011-11-30 21:21             ` Stephen Warren
2011-11-30 21:38             ` Nicolas Pitre
2011-11-30 21:50               ` Russell King - ARM Linux
2011-12-01  3:36                 ` Nicolas Pitre
2011-12-01 11:10               ` Mark Brown
2011-12-01 12:14                 ` Dave Martin
2011-12-01 16:19                   ` Stephen Warren
2011-12-02 17:41                     ` Stephen Warren
2011-12-02 19:06                       ` Marek Vasut
2011-12-02 19:28                       ` Dave Martin
2011-12-02 22:52                       ` Nicolas Pitre
2011-12-02 23:03                         ` Marek Vasut
2011-12-01 18:37                 ` Russell King - ARM Linux
2011-11-29 15:11 ` [PATCH v3 5/5] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Pawel Moll
2011-11-29 16:40   ` Dave Martin
2011-11-30 18:39     ` Pawel Moll
2011-12-01 12:21       ` Dave Martin
2011-12-05 17:24         ` Pawel Moll
2011-12-05 17:37           ` Dave Martin
2011-12-05 17:47             ` Pawel Moll
2011-12-05 18:06               ` Dave Martin
2011-11-29 17:00 ` [PATCH v3 0/5] Versatile Express DT support Dave Martin
2011-11-29 17:16   ` Pawel Moll
2011-11-30 10:48     ` Dave Martin
2011-11-30 11:14       ` Pawel Moll
2011-11-30 12:08         ` Dave Martin
2011-11-30 12:15           ` Pawel Moll
2011-11-29 21:24 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111130155800.GF2045@localhost.localdomain \
    --to=dave.martin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).