From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: backlight/ld9040.c: regulator control in the lcd driver
Date: Fri, 2 Dec 2011 10:31:40 +0000 [thread overview]
Message-ID: <20111202103139.GA8245@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAH9JG2XdDn26ziceug6-Dc8g3+z3AUuzL34-oHRy10qL2RjF2w@mail.gmail.com>
On Fri, Dec 02, 2011 at 05:57:35PM +0900, Kyungmin Park wrote:
> As mentioned at commit message, the lcd regulator is optional part and
> refer the mmc codes
> host->vmmc = regulator_get(mmc_dev(mmc), "vmmc");
> if (IS_ERR(host->vmmc)) {
> pr_info("%s: no vmmc regulator found\n", mmc_hostname(mmc));
> host->vmmc = NULL;
> } else {
> regulator_enable(host->vmmc);
> }
> Previous time, these codes are located at board file, but more boards
> are used, it has same codes for all boards. so move it to drivers.
In the case of MMC the MMC guys told us that this supply was entirely
optional for MMC operation, it wasn't an essential supply for the MMC
device to run it just enabled more features. For supplies like that
it's OK for the regulator to fail, the driver should just not do
whatever things are enabled by having that supply.
next prev parent reply other threads:[~2011-12-02 10:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 7:45 backlight/ld9040.c: regulator control in the lcd driver leedonghwa
2011-12-02 8:49 ` Linus Walleij
2011-12-02 8:57 ` Kyungmin Park
2011-12-02 10:05 ` Linus Walleij
2011-12-02 10:14 ` Kyungmin Park
2011-12-02 10:31 ` Mark Brown [this message]
2011-12-02 10:36 ` Linus Walleij
2011-12-02 10:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202103139.GA8245@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).