From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] irqdomain: protect macro variable in domain iterators
Date: Fri, 2 Dec 2011 13:44:58 +0000 [thread overview]
Message-ID: <20111202134458.GD2892@localhost.localdomain> (raw)
In-Reply-To: <1322832609-24956-1-git-send-email-nicolas.ferre@atmel.com>
On Fri, Dec 02, 2011 at 02:30:09PM +0100, Nicolas Ferre wrote:
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Looks OK to me:
Acked-by: Dave Martin <dave.martin@linaro.org>
> ---
> v2: add brackets to each macro variable.
>
> include/linux/irqdomain.h | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index bd4272b..e535063 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -82,12 +82,14 @@ static inline unsigned int irq_domain_to_irq(struct irq_domain *d,
> }
>
> #define irq_domain_for_each_hwirq(d, hw) \
> - for (hw = d->hwirq_base; hw < d->hwirq_base + d->nr_irq; hw++)
> + for ((hw) = (d)->hwirq_base; \
> + (hw) < (d)->hwirq_base + (d)->nr_irq; \
> + (hw)++)
>
> #define irq_domain_for_each_irq(d, hw, irq) \
> - for (hw = d->hwirq_base, irq = irq_domain_to_irq(d, hw); \
> - hw < d->hwirq_base + d->nr_irq; \
> - hw++, irq = irq_domain_to_irq(d, hw))
> + for ((hw) = (d)->hwirq_base, (irq) = irq_domain_to_irq((d), (hw)); \
> + (hw) < (d)->hwirq_base + (d)->nr_irq; \
> + (hw)++, (irq) = irq_domain_to_irq((d), (hw)))
>
> extern void irq_domain_add(struct irq_domain *domain);
> extern void irq_domain_del(struct irq_domain *domain);
> --
> 1.7.5.4
>
next prev parent reply other threads:[~2011-12-02 13:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 13:53 [PATCH] irqdomain: protect macro variable in domain iterators Nicolas Ferre
2011-12-02 12:59 ` Dave Martin
2011-12-02 13:25 ` Nicolas Ferre
2011-12-02 13:51 ` Rob Herring
2011-12-02 14:30 ` Dave Martin
2011-12-02 13:30 ` [PATCH v2] " Nicolas Ferre
2011-12-02 13:44 ` Dave Martin [this message]
2011-12-08 9:37 ` Nicolas Ferre
2011-12-08 13:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111202134458.GD2892@localhost.localdomain \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).