From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] backlight: add regulator support for platform_lcd driver
Date: Mon, 5 Dec 2011 10:33:16 +0000 [thread overview]
Message-ID: <20111205103315.GB11150@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAH9JG2XJ4TCEaN1rMRjMZNRn5Wx6jcTRC_DmyN4Qyf2zztWSsg@mail.gmail.com>
On Mon, Dec 05, 2011 at 07:10:03PM +0900, Kyungmin Park wrote:
> > + if (plcd->pdata->min_uV || plcd->pdata->max_uV)
> > + if (regulator_set_voltage(lcd_regulator,
> > + plcd->pdata->min_uV, plcd->pdata->max_uV))
> > + dev_info(plcd->us,
> > + "regulator voltage set failed\n");
> Are there case to change the voltage? Doesn't it easy to set the
> voltage at board file? I mean don't need to setup at drivers?
Yes, unless the driver changes the voltage it should just assume the
voltage is already set up sensibly and leave it up to the board to
do any configuration which is required on boot.
There is one existing driver which implements things this way in the
video subsystem but that should be fixed.
next prev parent reply other threads:[~2011-12-05 10:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 8:48 [PATCH] backlight: add regulator support for platform_lcd driver Thomas Abraham
2011-12-05 8:52 ` Felipe Balbi
2011-12-05 9:14 ` Thomas Abraham
2011-12-05 10:10 ` Kyungmin Park
2011-12-05 10:33 ` Mark Brown [this message]
2011-12-05 10:36 ` Thomas Abraham
2011-12-05 10:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205103315.GB11150@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).