linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4
Date: Mon, 5 Dec 2011 17:37:09 +0000	[thread overview]
Message-ID: <20111205173709.GA29812@localhost.localdomain> (raw)
In-Reply-To: <1323105880.3147.55.camel@hornet.cambridge.arm.com>

On Mon, Dec 05, 2011 at 05:24:40PM +0000, Pawel Moll wrote:
> On Thu, 2011-12-01 at 12:21 +0000, Dave Martin wrote:
> > That will work, but we should make it clear that this option does not
> > provide board support all by itself, maybe:
> > 
> > "Provides common dependencies for VE platforms based on Cortex-A5 or
> > Cortex-A9 processors.  In order to build a working kernel, you must also
> > enable one or more core tile support options."
> 
> Actually, the longer I think about it the more it seems that this code
> doesn't support a particular tile, but rather a particular processor...
> After all _exactly_ the same code will work with any SMM based on FPGA
> Logic Tile (V2F-2XV6), even if it was very different from the coretile,
> eg. A9 with RS1 memory map. In such case making it compatible with
> V2P-CA9 would be logically wrong...
> 
> I have an idea of spinning the compatible values again to get something
> like that:
> 
> compatible = "arm,vexpress-v2p-ca5s", "arm,vexpress-cortex_a5";
> compatible = "arm,vexpress-v2p-ca9", "arm,vexpress-cortex_a9";
> compatible = "arm,vexpress-v2p-ca15", "arm,vexpress-cortex_a15";

The trouble is, node { compatible = x } means "node is an x", not "node
has an x".

So, we should be careful do document what e.g. arm,vexpress-cortex_a5
actually means.  It doesn't mean Cortex-A5, but instead it represents
a whole jumble of characteristics which we expect to be common to all
vexpress-based A5 platforms.

It feels that in practice arm,vexpress-cortex_a5 actually means 
exactly the same thing as arm,vexpress-v2p-ca5s.  Are you sure these
two are really independent?  (In other words, do we expect multiple
different vexpress variants based on A5, and so on?)

Cheers
---Dave

  reply	other threads:[~2011-12-05 17:37 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-29 15:11 [PATCH v3 0/5] Versatile Express DT support Pawel Moll
2011-11-29 15:11 ` [PATCH v3 1/5] ARM: versatile: Add missing ENDPROC to headsmp.S Pawel Moll
2011-11-29 15:11 ` [PATCH v3 2/5] ARM: vexpress: Get rid of MMIO_P2V Pawel Moll
2011-11-29 21:15   ` Arnd Bergmann
2011-11-30 11:34     ` Pawel Moll
2011-11-30 13:48       ` Arnd Bergmann
2011-11-30 13:52         ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 3/5] ARM: vexpress: Add DT support in v2m Pawel Moll
2011-11-29 21:19   ` Arnd Bergmann
2011-11-30 11:46     ` Pawel Moll
2011-11-30 13:34       ` Arnd Bergmann
2011-11-30 13:38         ` Pawel Moll
2011-11-30 15:10           ` Arnd Bergmann
2011-11-30 15:58   ` Dave Martin
2011-11-30 18:46     ` Pawel Moll
2011-12-01 10:57       ` Dave Martin
2011-12-05 16:25   ` Dave Martin
2011-12-05 16:30     ` Pawel Moll
2011-11-29 15:11 ` [PATCH v3 4/5] ARM: vexpress: Initial RS1 memory map support Pawel Moll
2011-11-30 15:37   ` Dave Martin
2011-11-30 17:15     ` Pawel Moll
2011-11-30 17:54       ` Dave Martin
2011-11-30 18:31         ` Pawel Moll
2011-11-30 20:43         ` Nicolas Pitre
2011-11-30 20:48           ` Mark Brown
2011-11-30 21:21             ` Stephen Warren
2011-11-30 21:38             ` Nicolas Pitre
2011-11-30 21:50               ` Russell King - ARM Linux
2011-12-01  3:36                 ` Nicolas Pitre
2011-12-01 11:10               ` Mark Brown
2011-12-01 12:14                 ` Dave Martin
2011-12-01 16:19                   ` Stephen Warren
2011-12-02 17:41                     ` Stephen Warren
2011-12-02 19:06                       ` Marek Vasut
2011-12-02 19:28                       ` Dave Martin
2011-12-02 22:52                       ` Nicolas Pitre
2011-12-02 23:03                         ` Marek Vasut
2011-12-01 18:37                 ` Russell King - ARM Linux
2011-11-29 15:11 ` [PATCH v3 5/5] ARM: vexpress: DT-based support for CoreTiles Express A5x2 and A9x4 Pawel Moll
2011-11-29 16:40   ` Dave Martin
2011-11-30 18:39     ` Pawel Moll
2011-12-01 12:21       ` Dave Martin
2011-12-05 17:24         ` Pawel Moll
2011-12-05 17:37           ` Dave Martin [this message]
2011-12-05 17:47             ` Pawel Moll
2011-12-05 18:06               ` Dave Martin
2011-11-29 17:00 ` [PATCH v3 0/5] Versatile Express DT support Dave Martin
2011-11-29 17:16   ` Pawel Moll
2011-11-30 10:48     ` Dave Martin
2011-11-30 11:14       ` Pawel Moll
2011-11-30 12:08         ` Dave Martin
2011-11-30 12:15           ` Pawel Moll
2011-11-29 21:24 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111205173709.GA29812@localhost.localdomain \
    --to=dave.martin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).