From: cbouatmailru@gmail.com (Anton Vorontsov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver
Date: Tue, 6 Dec 2011 00:21:25 +0400 [thread overview]
Message-ID: <20111205202125.GA32592@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <4EDD1897.4030208@gmail.com>
On Mon, Dec 05, 2011 at 01:16:39PM -0600, Rob Herring wrote:
[...]
> At least for DT enabled platforms, we could force "no irq" to be 0 in
> the DT irq code. Searching the dts files, I found 2 occurrences of IRQ0.
Please note that there are HW IRQ numbers and "Virtual" IRQ numbers.
dev->irq and thus the thing that we pass into request_irq() is a
virtual IRQ thing, a "cookie".
While in device tree you see real HW IRQ numbers.
Legal VIRQ is always > 0, while HW IRQ could be >= 0.
> Prima2 has timer on IRQ0, and VersatileAB has watchdog on IRQ0. Prima2
> should be fine currently as it doesn't use the of_irq_* functions to get
> the timer irq, but that is an issue as it skips any translation.
> VersatileAB should be okay with the VIC irqdomain support.
It shouldn't be an issue to use of_irq_*() functions for these IRQs.
of_irq_*() will remap HW IRQ 0 to some other VIRQ. If it does not do
this currently, then it's a bug and should be fixed.
Thanks,
--
Anton Vorontsov
Email: cbouatmailru at gmail.com
next prev parent reply other threads:[~2011-12-05 20:21 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111110162859.GA7088@oksana.dev.rtsoft.ru>
[not found] ` <20111202192618.GC3037@localhost.localdomain>
2011-12-02 19:28 ` [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver Linus Torvalds
2011-12-02 23:12 ` Benjamin Herrenschmidt
2011-12-05 16:11 ` Dave Martin
2011-12-05 17:40 ` Nicolas Pitre
2011-12-05 18:02 ` Dave Martin
2011-12-05 18:15 ` Geert Uytterhoeven
2011-12-05 18:18 ` Nicolas Pitre
2011-12-05 18:45 ` Alan Cox
2011-12-05 19:19 ` James Bottomley
2011-12-06 6:13 ` Jean-Christophe PLAGNIOL-VILLARD
2011-12-06 11:34 ` Alan Cox
2011-12-05 19:16 ` Rob Herring
2011-12-05 20:21 ` Anton Vorontsov [this message]
2011-12-05 20:47 ` Rob Herring
2011-12-05 20:53 ` Alan Cox
2011-12-06 9:30 ` Dave Martin
2011-12-06 10:34 ` Alan Cox
2011-12-06 10:55 ` Russell King - ARM Linux
2011-12-05 19:26 ` Dave Martin
2011-12-05 19:49 ` Nicolas Pitre
2011-12-06 9:37 ` Dave Martin
2011-12-06 10:46 ` Russell King - ARM Linux
2011-12-06 11:00 ` Geert Uytterhoeven
2011-12-06 11:03 ` Russell King - ARM Linux
2011-12-06 11:10 ` Alan Cox
2011-12-06 11:05 ` Alan Cox
2011-12-06 11:25 ` Russell King - ARM Linux
2011-12-06 12:11 ` Alan Cox
2011-12-06 11:37 ` Dave Martin
2011-12-06 11:49 ` Russell King - ARM Linux
2011-12-06 13:25 ` Dave Martin
2011-12-06 19:56 ` Rob Herring
2011-12-06 19:20 ` Linus Torvalds
2011-12-06 20:00 ` Russell King - ARM Linux
2011-12-06 20:59 ` Uwe Kleine-König
2011-12-06 19:11 ` Nicolas Pitre
2011-12-05 17:41 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111205202125.GA32592@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).