From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] [media] V4L: atmel-isi: add code to enable/disable ISI_MCK clock
Date: Wed, 7 Dec 2011 08:49:58 +0000 [thread overview]
Message-ID: <20111207084958.GA14542@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1322647604-30662-1-git-send-email-josh.wu@atmel.com>
On Wed, Nov 30, 2011 at 06:06:43PM +0800, Josh Wu wrote:
> + /* Get ISI_MCK, provided by programmable clock or external clock */
> + isi->mck = clk_get(dev, "isi_mck");
> + if (IS_ERR_OR_NULL(isi->mck)) {
This should be IS_ERR()
> + dev_err(dev, "Failed to get isi_mck\n");
> + ret = isi->mck ? PTR_ERR(isi->mck) : -EINVAL;
ret = PTR_ERR(isi->mck);
next prev parent reply other threads:[~2011-12-07 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 10:06 [PATCH 1/2] [media] V4L: atmel-isi: add code to enable/disable ISI_MCK clock Josh Wu
2011-11-30 10:06 ` [PATCH 2/2] [media] V4L: atmel-isi: add clk_prepare()/clk_unprepare() functions Josh Wu
2011-12-06 9:49 ` Guennadi Liakhovetski
2011-12-07 6:09 ` Wu, Josh
2011-12-07 8:49 ` Russell King - ARM Linux [this message]
2011-12-07 10:12 ` [PATCH 1/2] [media] V4L: atmel-isi: add code to enable/disableISI_MCK clock Wu, Josh
2011-12-07 22:39 ` Russell King - ARM Linux
2011-12-08 3:18 ` [PATCH 1/2] [media] V4L: atmel-isi: add code toenable/disableISI_MCK clock Wu, Josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207084958.GA14542@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).