From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] spi/pl022: move device disable to workqueue thread
Date: Wed, 7 Dec 2011 21:22:03 +0100 [thread overview]
Message-ID: <20111207202203.GA3744@pengutronix.de> (raw)
In-Reply-To: <CACRpkdYSGWAB29gHhKjpyEQDAaLoTbPM6-Qz0FosL3X4TNwxdg@mail.gmail.com>
Hi Linus,
On Tue, Nov 22, 2011 at 10:28:44AM +0100, Linus Walleij wrote:
> On Tue, Nov 22, 2011 at 9:28 AM, Viresh Kumar <viresh.kumar@st.com> wrote:
> > On 11/22/2011 1:55 PM, Linus WALLEIJ wrote:
> >> ? ? ? if (list_empty(&pl022->queue) || !pl022->running) {
> >> + ? ? ? ? ? ? if (pl022->busy) {
> >> + ? ? ? ? ? ? ? ? ? ? pm_runtime_put(&pl022->adev->dev);
> >> + ? ? ? ? ? ? }
> >
> > We used to get warnings from checkpatch, for single line code inside {}.
> > Don't we get them anymore?
>
> It's driven by heuristics, I think it only warns on the first level since
> elsewhere you may want braces for readability.
>
> But I'll take it out when I add you Reviewed-by...
Does that imply you will send out a V3 of this series somewhen and I
don't need to add this right now to the for-grant branch I am currently
preparing?
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111207/b856cd69/attachment.sig>
next prev parent reply other threads:[~2011-12-07 20:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 8:25 [PATCH 4/7] spi/pl022: move device disable to workqueue thread Linus Walleij
2011-11-22 8:28 ` Viresh Kumar
2011-11-22 9:28 ` Linus Walleij
2011-12-07 20:22 ` Wolfram Sang [this message]
2011-12-07 22:38 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111207202203.GA3744@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).