linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [MXS MMC v2 0/4] Some cleanups and fixes for the MXS MMC subsystem
@ 2011-12-08  8:17 Lothar Waßmann
  2011-12-08  8:52 ` Wolfram Sang
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Lothar Waßmann @ 2011-12-08  8:17 UTC (permalink / raw)
  To: linux-arm-kernel

Lothar Wa??mann (4):
  Fix grammatical error in comment
  Some cleanups for the MMC driver
  Check the return codes of clk_enable() and mxs_reset_block()
  Add an appropriate MODULE_ALIAS

Changes wrt v1:
 - omitted patch 3 "Add support for MMC ports 2 & 3" which has already
   been applied by Shawn Guo
 - fix checkpatch warnings in patch 2 and leave indentation as is
 - add Acked-by: where applicable

 drivers/mmc/host/mxs-mmc.c |   87 +++++++++++++++++++++++++++------------------
 1 file changed, 54 insertions(+), 33 deletions(-)

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MXS MMC v2 0/4] Some cleanups and fixes for the MXS MMC subsystem
  2011-12-08  8:17 [MXS MMC v2 0/4] Some cleanups and fixes for the MXS MMC subsystem Lothar Waßmann
@ 2011-12-08  8:52 ` Wolfram Sang
       [not found] ` <1ebaeb7f7ed88b1d82f5fc3a01c0661f38e2a16d.1323328267.git.LW@KARO-electronics.de>
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2011-12-08  8:52 UTC (permalink / raw)
  To: linux-arm-kernel

>  - add Acked-by: where applicable

You forgot mine :( Will resend.

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111208/40fa1b31/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MXS MMC v2 1/4] Fix grammatical error in comment
       [not found] ` <1ebaeb7f7ed88b1d82f5fc3a01c0661f38e2a16d.1323328267.git.LW@KARO-electronics.de>
@ 2011-12-08  8:52   ` Wolfram Sang
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2011-12-08  8:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 08, 2011 at 09:17:44AM +0100, Lothar Wa?mann wrote:
> 
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111208/c9fbe2fd/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MXS MMC v2 3/4] Check the return codes of clk_enable() and mxs_reset_block()
       [not found] ` <b4779523002ceef3e95887bbcf7ed570cdd93a95.1323328267.git.LW@KARO-electronics.de>
@ 2011-12-08  8:53   ` Wolfram Sang
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2011-12-08  8:53 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 08, 2011 at 09:17:46AM +0100, Lothar Wa?mann wrote:
> Add an int return value to mxs_mmc_reset(), so that the return code of
> mxs_reset_block() can be promoted to the caller.
> Also check the return code of clk_enable() in the probe function.
> 
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>

Despite minor nit that using __func__ is probably overkill:

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111208/b700d403/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MXS MMC 4/4] Add an appropriate MODULE_ALIAS
       [not found] ` <b1c45bfdbc9323b2a6c50ce213a3e895aeea2b2f.1323328267.git.LW@KARO-electronics.de>
@ 2011-12-08  8:54   ` Wolfram Sang
  0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2011-12-08  8:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 08, 2011 at 09:17:47AM +0100, Lothar Wa?mann wrote:
> 
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>
> Acked-by: Shawn Guo <shawn.guo@linaro.org>

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111208/f2dce507/attachment.sig>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [MXS MMC v2 2/4] Some cleanups for the MMC driver
       [not found] ` <d935557e044d2ebc56b4e70487b519fe722e9017.1323328267.git.LW@KARO-electronics.de>
@ 2011-12-08  9:17   ` Shawn Guo
  0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2011-12-08  9:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 08, 2011 at 09:17:45AM +0100, Lothar Wa?mann wrote:
>  - Remove bogus parens around numerical arguments in #define's
>  - When defining bit masks, use the #def for the shift count
>    instead of repeating the numbers
>  - Remove 'break' at end of switch statement
> 
> Changes wrt v1:
>  - break long lines
>  - leave indentation as is
> 
> Signed-off-by: Lothar Wa?mann <LW@KARO-electronics.de>

Acked-by: Shawn Guo <shawn.guo@linaro.org>

Not sure if Chris will ask you to add proper subject prefix though :)

-- 
Regards,
Shawn

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-12-08  9:17 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-08  8:17 [MXS MMC v2 0/4] Some cleanups and fixes for the MXS MMC subsystem Lothar Waßmann
2011-12-08  8:52 ` Wolfram Sang
     [not found] ` <1ebaeb7f7ed88b1d82f5fc3a01c0661f38e2a16d.1323328267.git.LW@KARO-electronics.de>
2011-12-08  8:52   ` [MXS MMC v2 1/4] Fix grammatical error in comment Wolfram Sang
     [not found] ` <b4779523002ceef3e95887bbcf7ed570cdd93a95.1323328267.git.LW@KARO-electronics.de>
2011-12-08  8:53   ` [MXS MMC v2 3/4] Check the return codes of clk_enable() and mxs_reset_block() Wolfram Sang
     [not found] ` <b1c45bfdbc9323b2a6c50ce213a3e895aeea2b2f.1323328267.git.LW@KARO-electronics.de>
2011-12-08  8:54   ` [MXS MMC 4/4] Add an appropriate MODULE_ALIAS Wolfram Sang
     [not found] ` <d935557e044d2ebc56b4e70487b519fe722e9017.1323328267.git.LW@KARO-electronics.de>
2011-12-08  9:17   ` [MXS MMC v2 2/4] Some cleanups for the MMC driver Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).