From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] amp/omap: add a remoteproc driver
Date: Thu, 8 Dec 2011 09:01:14 -0800 [thread overview]
Message-ID: <20111208170114.GZ31337@atomide.com> (raw)
In-Reply-To: <CAK=WgbZvH3eiouryKDenC_x0LdDcHFuumhfoeY4ueiwT5r0cxA@mail.gmail.com>
* Ohad Ben-Cohen <ohad@wizery.com> [111207 23:26]:
> Hi Tony,
>
> On Tue, Oct 25, 2011 at 11:48 AM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
> > Add a remoteproc driver for OMAP4, so we can boot the dual-M3 "Ducati"
> > and DSP subsystems.
> >
> > Use the omap_device_* API to control the hardware state, and utilize
> > the OMAP mailbox to interrupt the remote processor when a new message
> > is pending (the mailbox payload is used to tell it which virtqueue was
> > the message placed in).
> >
> > Conversely, when an inbound mailbox message arrives, tell the remoteproc
> > core which virtqueue is triggered.
> >
> > Later we will also use the mailbox payload to signal omap-specific
> > events like remote crashes (which will be used to trigger remoteproc
> > recovery) and power management transitions. At that point we will also
> > extend the remoteproc core to support this.
> >
> > Based on (but now quite far from) work done by Fernando Guzman Lugo
> > <fernando.lugo@ti.com> and Hari Kanigeri <h-kanigeri2@ti.com>.
> >
> > Designed with Brian Swetland <swetland@google.com>.
> >
> > Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
> > Cc: Brian Swetland <swetland@google.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: Rusty Russell <rusty@rustcorp.com.au>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Greg KH <greg@kroah.com>
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> > ?arch/arm/plat-omap/include/plat/remoteproc.h | ? 56 ++++++
> > ?drivers/amp/remoteproc/Kconfig ? ? ? ? ? ? ? | ? 21 +++
> > ?drivers/amp/remoteproc/Makefile ? ? ? ? ? ? ?| ? ?4 +-
> > ?drivers/amp/remoteproc/omap_remoteproc.c ? ? | ?248 ++++++++++++++++++++++++++
> > ?drivers/amp/remoteproc/omap_remoteproc.h ? ? | ? 69 +++++++
> > ?5 files changed, 397 insertions(+), 1 deletions(-)
> > ?create mode 100644 arch/arm/plat-omap/include/plat/remoteproc.h
> > ?create mode 100644 drivers/amp/remoteproc/omap_remoteproc.c
> > ?create mode 100644 drivers/amp/remoteproc/omap_remoteproc.h
>
> I'm about to add this to linux-next (minus the 'amp' wording); can I
> please have your Acked-by for this (at least for the plat-omap change) ?
The platform init code looks OK to me. Please also start considering
how to do the DT bindings for it. For patches 4 & 5:
Acked-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2011-12-08 17:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 9:48 [PATCH 0/7] Introducing a generic AMP framework Ohad Ben-Cohen
2011-10-25 9:48 ` [PATCH 1/7] amp/remoteproc: add framework for controlling remote processors Ohad Ben-Cohen
2011-10-26 5:16 ` Jean-Christophe PLAGNIOL-VILLARD
2011-10-26 5:25 ` Ohad Ben-Cohen
2011-11-23 3:27 ` Stephen Boyd
2011-11-23 15:34 ` Ohad Ben-Cohen
2012-01-03 23:35 ` Grant Likely
2012-01-04 7:29 ` Mark Grosen
2012-01-05 13:58 ` Ohad Ben-Cohen
2011-10-25 9:48 ` [PATCH 2/7] amp/remoteproc: add debugfs entries Ohad Ben-Cohen
2012-01-03 23:36 ` Grant Likely
2011-10-25 9:48 ` [PATCH 3/7] amp/remoteproc: create rpmsg virtio device Ohad Ben-Cohen
2011-10-25 9:48 ` [PATCH 4/7] amp/omap: add a remoteproc driver Ohad Ben-Cohen
2011-12-08 7:57 ` Ohad Ben-Cohen
2011-12-08 17:01 ` Tony Lindgren [this message]
2011-12-08 17:08 ` Ohad Ben-Cohen
2011-10-25 9:48 ` [PATCH 5/7] ARM: OMAP: add amp/remoteproc support Ohad Ben-Cohen
2011-10-25 9:48 ` [PATCH 6/7] amp/rpmsg: add virtio-based remote processor messaging bus Ohad Ben-Cohen
2011-10-25 9:48 ` [PATCH 7/7] samples/amp: add an rpmsg driver sample Ohad Ben-Cohen
2011-10-26 4:00 ` [PATCH 0/7] Introducing a generic AMP framework Rusty Russell
2011-10-26 5:26 ` Ohad Ben-Cohen
2011-11-22 11:40 ` Ohad Ben-Cohen
2011-11-23 1:33 ` Rusty Russell
2011-11-23 9:58 ` Ohad Ben-Cohen
2011-12-08 7:50 ` Ohad Ben-Cohen
2011-12-09 5:38 ` Rusty Russell
2011-12-09 14:15 ` Ohad Ben-Cohen
2011-11-23 3:25 ` Saravana Kannan
2011-11-23 10:27 ` Ohad Ben-Cohen
2011-11-23 16:10 ` Mark Brown
2011-11-23 20:28 ` Saravana Kannan
2011-11-24 8:43 ` Ohad Ben-Cohen
2011-12-06 22:09 ` Saravana Kannan
2011-12-07 18:53 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208170114.GZ31337@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).