linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] OMAP2+: DMA: Workaround for invalid source position
Date: Thu, 8 Dec 2011 16:42:01 -0800	[thread overview]
Message-ID: <20111209004201.GI31337@atomide.com> (raw)
In-Reply-To: <1857964.6c1BL8cmCX@barack>

* P?ter Ujfalusi <peter.ujfalusi@ti.com> [111129 04:26]:
> On Thursday 10 November 2011 15:02:04 Jarkko Nikula wrote:
> > On 11/10/2011 02:46 PM, Jarkko Nikula wrote:
> > > On 11/07/2011 11:33 AM, Peter Ujfalusi wrote:
> > > 
> > > I think this is enough:
> > > 
> > > if (unlikely(p->dma_read(CDAC, lch) == 0))
> > > offset = p->dma_read(CSSA, lch);
> > > 
> > > I suppose offset is ok for normal case as it is already read (twise)
> > > above.
> > Or actually my proposal could have a race if CDAC changes between CSAC
> > read and CDAC read. In that case it's better to re-read CSAC as your
> > patch does after CDAC test and give to both:
> > 
> > Reviewed-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
> 
> Tony, have you taken this patch? I failed to find it in the l-o tree...

Sorry for the delay, applying both into fixes-non-critical.

Tony

  reply	other threads:[~2011-12-09  0:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07  9:33 [PATCH v2 0/2] OMAP2+: DMA: fix src/dst position reporting Peter Ujfalusi
2011-11-07  9:33 ` [PATCH v2 1/2] OMAP2+: DMA: Workaround for invalid source position Peter Ujfalusi
2011-11-10 12:46   ` Jarkko Nikula
2011-11-10 13:02     ` Jarkko Nikula
2011-11-29 13:01       ` Péter Ujfalusi
2011-12-09  0:42         ` Tony Lindgren [this message]
2011-11-07  9:33 ` [PATCH v2 2/2] OMAP2+: DMA: Workaround for invalid destination position Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111209004201.GI31337@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).