From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] Use generic ARM instruction set condition code checks for kprobes.
Date: Fri, 9 Dec 2011 16:40:29 +0000 [thread overview]
Message-ID: <20111209164029.GL5196@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <4EE234A8.80208@arm.com>
On Fri, Dec 09, 2011 at 04:17:44PM +0000, Leif Lindholm wrote:
> On 12/09/11 15:54, Will Deacon wrote:
> > On Thu, Dec 08, 2011 at 05:32:13PM +0000, Leif Lindholm wrote:
> >> -static unsigned long test_check_cc(int cc, unsigned long cpsr)
> >> +inline unsigned long test_check_cc(int cc, unsigned long cpsr)
> >
> > Not sure why you make this change, surely you can just leave it as static?
>
> As the function is now only a wrapper on arm_check_condition (with an
> inline shift), it made more sense to me. This was also suggested by
> Tixy, and he's since ACKed this patch.
Hmm, I still don't see why you should change the linkage. Make it static
inline if you really want the inline, but that seems weird outside of a
header file stub.
> > Maybe it's best just to change all of the callers to call
> > arm_check_condition directly, like you have done below for the ARM case. For
> > the Thumb cases will it work if you make sure that you put the condition
> > code in the top bits?
>
> Yes, that is functionally equivalent, and what I did in the RFC version,
> but it ended up looking messy at the calling point.
Ok, then could you route the ARM variant through the wrapper too?
> Any sane compiler should generate pretty identical code for these two
> alternative solutions (unless it neglected to auto-inline the static
> variant).
The problem is when somebody else decides to call test_check_cc from another
compilation unit, rather than go through arm_check_condition.
Will
next prev parent reply other threads:[~2011-12-09 16:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 17:31 [PATCH 0/4] Add generic ARM ISA condition code check Leif Lindholm
2011-12-08 17:31 ` [PATCH 1/4] Add generic ARM instruction set condition code checks Leif Lindholm
2011-12-09 15:36 ` Will Deacon
2011-12-09 17:50 ` Leif Lindholm
2011-12-08 17:31 ` [PATCH 2/4] Use generic ARM instruction set condition code checks for nwfpe Leif Lindholm
2011-12-08 17:32 ` [PATCH 3/4] Add condition code checking to SWP emulation handler Leif Lindholm
2011-12-09 16:06 ` Will Deacon
2011-12-08 17:32 ` [PATCH 4/4] Use generic ARM instruction set condition code checks for kprobes Leif Lindholm
2011-12-09 15:54 ` Will Deacon
2011-12-09 16:17 ` Leif Lindholm
2011-12-09 16:40 ` Will Deacon [this message]
2011-12-09 17:48 ` Leif Lindholm
2011-12-09 18:05 ` Jon Medhurst (Tixy)
2011-12-09 18:26 ` Leif Lindholm
2011-12-09 18:26 ` Leif Lindholm
2011-12-09 15:27 ` [PATCH 0/4] Add generic ARM ISA condition code check Will Deacon
2011-12-09 15:29 ` Dave Martin
-- strict thread matches above, loose matches on Subject: below --
2011-12-09 18:54 [PATCH 0/4] Add generic ARM ISA condition code check v3 Leif Lindholm
2011-12-09 18:55 ` [PATCH 4/4] Use generic ARM instruction set condition code checks for kprobes Leif Lindholm
2011-12-10 9:19 ` Tixy
2011-12-10 13:24 ` Will Deacon
2011-11-25 17:19 [PATCH 0/4] Add generic ARM ISA condition code checks Leif Lindholm
2011-11-25 17:20 ` [PATCH 4/4] Use generic ARM instruction set condition code checks for kprobes Leif Lindholm
2011-11-27 12:24 ` Tixy
2011-11-30 17:02 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209164029.GL5196@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).