From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: provide XIP_VIRT_ADDR for no-MMU builds
Date: Sat, 10 Dec 2011 10:11:22 +0000 [thread overview]
Message-ID: <20111210101122.GO14542@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20111210095253.GV4585@pengutronix.de>
On Sat, Dec 10, 2011 at 10:52:53AM +0100, Uwe Kleine-K?nig wrote:
> On Sat, Dec 10, 2011 at 01:02:21AM +0000, Russell King - ARM Linux wrote:
> > On Fri, Dec 09, 2011 at 10:50:51PM +0100, Uwe Kleine-K?nig wrote:
> > > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> >
> > Lack of changelog. Say why this change is required.
> Something like:
>
> XIP_VIRT_ADDR is needed for XIP builds and currently only
> defined for builds with CONFIG_MMU.
>
> Also provide it for no-MMU builds to make it possible to build
> an XIP kernel for MMU-less machines. As these lack an MMU it has
> to be an identity mapping.
You seem to be saying from the above that this is required also for
non-XIP kernel builds as well as XIP kernel builds. That sounds wrong -
XIP_VIRT_ADDR is only required for XIP kernel builds. Use outside of
that would be a bug.
Please clarify.
(And this illustrates why it is very important to give an explanation
of changes.)
next prev parent reply other threads:[~2011-12-10 10:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 21:50 [PATCH] ARM: provide XIP_VIRT_ADDR for no-MMU builds Uwe Kleine-König
2011-12-09 23:12 ` Nicolas Pitre
2011-12-10 1:02 ` Russell King - ARM Linux
2011-12-10 9:52 ` Uwe Kleine-König
2011-12-10 10:11 ` Russell King - ARM Linux [this message]
2011-12-10 21:58 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111210101122.GO14542@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).