From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] ARM: SMP: Refactor Kconfig to be more maintainable
Date: Mon, 12 Dec 2011 15:59:12 +0000 [thread overview]
Message-ID: <20111212155912.GB20178@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20111212150405.GB2296@linaro.org>
On Mon, Dec 12, 2011 at 03:04:05PM +0000, Dave Martin wrote:
> On Mon, Dec 12, 2011 at 02:10:01PM +0000, Russell King - ARM Linux wrote:
> > On Mon, Dec 12, 2011 at 11:47:06AM +0000, Dave Martin wrote:
> > > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > > index 4234937..4aa7f7e 100644
> > > --- a/arch/arm/mach-imx/Kconfig
> > > +++ b/arch/arm/mach-imx/Kconfig
> > > @@ -611,6 +611,7 @@ config SOC_IMX6Q
> > > select ARM_GIC
> > > select CPU_V7
> > > select HAVE_ARM_SCU
> > > + select HAVE_SMP
> > > select HAVE_IMX_GPC
> > > select HAVE_IMX_MMDC
> > > select HAVE_IMX_SRC
> >
> > NAK. I'll let you work out why. It has something to do with ABCDEFGH...
>
> Duh. Sorry about that -- will fix and repost.
>
>
> Do you have a preference about where to insert new items where the list
> is not already in alphabetical order?
What I've done in the past is roughly to ignore anything which isn't
alphabetical from the top, and place it within that subset. I
simetimes change that (if there's a group of HAVE_xxx which is already
sorted, I add it within that sub-group.)
In other words, try to sensibly place it so the addition itself is
alphabetically between two other options which are already so sorted.
next prev parent reply other threads:[~2011-12-12 15:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 11:47 [PATCH v3 0/2] Refactor common Kconfigs for easier maintenance Dave Martin
2011-12-12 11:47 ` [PATCH v3 1/2] ARM: pl2x0/pl310: Refactor Kconfig to be more maintainable Dave Martin
2011-12-12 14:08 ` Russell King - ARM Linux
2011-12-12 15:01 ` Dave Martin
2011-12-12 16:04 ` Russell King - ARM Linux
2011-12-12 16:53 ` Dave Martin
2011-12-12 22:22 ` Russell King - ARM Linux
2011-12-12 15:19 ` Dave Martin
2011-12-12 11:47 ` [PATCH v3 2/2] ARM: SMP: " Dave Martin
2011-12-12 14:10 ` Russell King - ARM Linux
2011-12-12 15:04 ` Dave Martin
2011-12-12 15:59 ` Russell King - ARM Linux [this message]
2011-12-12 16:40 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212155912.GB20178@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).