From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] mfd: Fixed mixed up ADC single channel readout
Date: Mon, 12 Dec 2011 18:10:43 +0100 [thread overview]
Message-ID: <20111212171043.GC4585@pengutronix.de> (raw)
In-Reply-To: <20111212171243.GQ13952@sortiz-mobl>
On Mon, Dec 12, 2011 at 06:12:43PM +0100, Samuel Ortiz wrote:
> Hi Robin,
>
> On Mon, Nov 28, 2011 at 12:20:47PM +0100, Robin van der Gracht wrote:
> > In single channel mode, when reading the ADC result, the index value
> > is still set to the channel selected for this reading.
> > This mixes up the order of the values returned. This causes problems when
> > the converted results are made available in pairs (i.e. battery current reading)
> > To straighten this up, the index value needs to be reset, so that the
> > converted values are read at the assigned channel.
> >
> > Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> I'm not familiar with the HW, so I'd need Uwe's ACK here.
Off-hand I don't understand that patch. David, I assume you understood
the patch and are OK with it? That would be enough for me.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2011-12-12 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-28 11:20 [PATCH V2] mfd: Fixed mixed up ADC single channel readout Robin van der Gracht
2011-12-12 17:12 ` Samuel Ortiz
2011-12-12 17:10 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111212171043.GC4585@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).