From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio: pl061: drop extra check for NULL platform_data
Date: Tue, 13 Dec 2011 11:02:27 -0700 [thread overview]
Message-ID: <20111213180227.GA4871@ponder.secretlab.ca> (raw)
In-Reply-To: <1323471368-7955-1-git-send-email-robherring2@gmail.com>
On Fri, Dec 09, 2011 at 04:56:08PM -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
>
> In adding DT binding support, the check for NULL platform_data got added
> back in inadvertently, so remove it.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
Applied, thanks.
g.
> ---
> Linus or Grant,
>
> Can you apply this fix for 3.2-rc.
>
> Thanks,
> Rob
>
> drivers/gpio/gpio-pl061.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pl061.c b/drivers/gpio/gpio-pl061.c
> index 093c90b..4102f63 100644
> --- a/drivers/gpio/gpio-pl061.c
> +++ b/drivers/gpio/gpio-pl061.c
> @@ -238,10 +238,6 @@ static int pl061_probe(struct amba_device *dev, const struct amba_id *id)
> int ret, irq, i;
> static DECLARE_BITMAP(init_irq, NR_IRQS);
>
> - pdata = dev->dev.platform_data;
> - if (pdata == NULL)
> - return -ENODEV;
> -
> chip = kzalloc(sizeof(*chip), GFP_KERNEL);
> if (chip == NULL)
> return -ENOMEM;
> --
> 1.7.5.4
>
prev parent reply other threads:[~2011-12-13 18:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-09 22:56 [PATCH] gpio: pl061: drop extra check for NULL platform_data Rob Herring
2011-12-13 18:02 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213180227.GA4871@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).