From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv11 2/8] ARM: OMAP2+: hwmod: Add API to check IO PAD wakeup status
Date: Tue, 13 Dec 2011 14:28:04 -0800 [thread overview]
Message-ID: <20111213222804.GV32251@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1112131505000.12046@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [111213 13:44]:
> Hi
>
> a question
>
> On Mon, 12 Dec 2011, Tero Kristo wrote:
>
> So the patch description says:
>
> > From: R, Govindraj <govindraj.raja@ti.com>
> >
> > Add API to determine IO-PAD wakeup event status for a given
> > hwmod dynamic_mux pad.
>
> But the code does:
>
> > + for (i = 0; i < hmux->nr_pads; i++) {
> > + struct omap_device_pad *pad = &hmux->pads[i];
>
> which is going to check all of the pads, not just the dynamic ones.
>
> So it seems to me that we need to decide whether this code should be
> testing all the pads, or just the dynamically remuxed ones. The same
> thing should be decided for the code in patch 1.
>
> Na?vely it seems to me that we want to test all of the pads in both
> patches 1 and 2, not just the dynamically remuxable ones. Comments?
You're right, it should be only the dynamic ones.
Tony
next prev parent reply other threads:[~2011-12-13 22:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 18:15 [PATCHv11 0/8] OMAP3+: PRCM chain handler Tero Kristo
2011-12-12 18:15 ` [PATCHv11 1/8] ARM: OMAP2+: hwmod: Add API to enable IO ring wakeup Tero Kristo
2011-12-13 20:51 ` Paul Walmsley
2011-12-13 21:04 ` Paul Walmsley
2011-12-13 21:33 ` Paul Walmsley
2011-12-14 2:34 ` Paul Walmsley
2011-12-14 10:02 ` Tero Kristo
2011-12-12 18:15 ` [PATCHv11 2/8] ARM: OMAP2+: hwmod: Add API to check IO PAD wakeup status Tero Kristo
2011-12-13 0:28 ` Tony Lindgren
2011-12-13 22:16 ` Paul Walmsley
2011-12-13 22:28 ` Tony Lindgren [this message]
2011-12-13 22:38 ` Paul Walmsley
2011-12-13 22:48 ` Tony Lindgren
2011-12-14 2:22 ` Paul Walmsley
2011-12-14 10:17 ` Tero Kristo
2011-12-14 3:04 ` Paul Walmsley
2011-12-14 10:13 ` Tero Kristo
2011-12-12 18:15 ` [PATCHv11 3/8] ARM: OMAP: prm: add support for chain interrupt handler Tero Kristo
2011-12-13 0:27 ` Tony Lindgren
2011-12-12 18:15 ` [PATCHv11 4/8] ARM: OMAP: prcm: add suspend prepare / finish support Tero Kristo
2011-12-12 18:15 ` [PATCHv11 5/8] ARM: OMAP2+: mux: add support for PAD wakeup interrupts Tero Kristo
2011-12-13 0:24 ` Tony Lindgren
2011-12-12 18:15 ` [PATCHv11 6/8] ARM: OMAP3: pm: use prcm chain handler Tero Kristo
2011-12-12 18:15 ` [PATCHv11 7/8] ARM: OMAP3: pm: do not enable PRCM MPU interrupts manually Tero Kristo
2011-12-12 18:15 ` [PATCHv11 8/8] ARM: OMAP: mux: add support for selecting mpu_irq for each wakeup pad Tero Kristo
2011-12-13 0:25 ` Tony Lindgren
2011-12-13 0:33 ` [PATCHv11 0/8] OMAP3+: PRCM chain handler Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213222804.GV32251@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).