* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
@ 2011-12-06 16:49 Benoit Cousson
2011-12-13 13:27 ` Tomi Valkeinen
2012-01-04 20:11 ` Grant Likely
0 siblings, 2 replies; 9+ messages in thread
From: Benoit Cousson @ 2011-12-06 16:49 UTC (permalink / raw)
To: linux-arm-kernel
devicetree will become the mandatory boot method for OMAP2+.
In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
select USE_OF by default for every OMAP2+ systems.
Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
boot loader to keep working properly.
Enable PROC_DEVICETREE as well.
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/Kconfig | 1 -
arch/arm/plat-omap/Kconfig | 4 ++++
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index e1293aa..056a812 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -109,7 +109,6 @@ comment "OMAP Board Type"
config MACH_OMAP_GENERIC
bool "Generic OMAP2+ board"
depends on ARCH_OMAP2PLUS
- select USE_OF
default y
help
Support for generic TI OMAP2+ boards using Flattened Device Tree.
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index aa59f42..74f41dc 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -24,6 +24,10 @@ config ARCH_OMAP2PLUS
select CLKDEV_LOOKUP
select GENERIC_IRQ_CHIP
select OMAP_DM_TIMER
+ select USE_OF
+ select ARM_APPENDED_DTB
+ select ARM_ATAG_DTB_COMPAT
+ select PROC_DEVICETREE
help
"Systems based on OMAP2, OMAP3 or OMAP4"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-06 16:49 [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems Benoit Cousson
@ 2011-12-13 13:27 ` Tomi Valkeinen
2011-12-13 13:34 ` Cousson, Benoit
2012-01-04 20:11 ` Grant Likely
1 sibling, 1 reply; 9+ messages in thread
From: Tomi Valkeinen @ 2011-12-13 13:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Tue, 2011-12-06 at 17:49 +0100, Benoit Cousson wrote:
> devicetree will become the mandatory boot method for OMAP2+.
> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
> select USE_OF by default for every OMAP2+ systems.
> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
> boot loader to keep working properly.
APPENDED_DTB sounds a bit dangerous to be enabled by default according
to the config help text.
Tomi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20111213/4fa39ab4/attachment.sig>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-13 13:27 ` Tomi Valkeinen
@ 2011-12-13 13:34 ` Cousson, Benoit
2011-12-13 22:38 ` Tony Lindgren
0 siblings, 1 reply; 9+ messages in thread
From: Cousson, Benoit @ 2011-12-13 13:34 UTC (permalink / raw)
To: linux-arm-kernel
On 12/13/2011 2:27 PM, Tomi Valkeinen wrote:
> Hi,
>
> On Tue, 2011-12-06 at 17:49 +0100, Benoit Cousson wrote:
>> devicetree will become the mandatory boot method for OMAP2+.
>> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
>> select USE_OF by default for every OMAP2+ systems.
>> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
>> boot loader to keep working properly.
>
> APPENDED_DTB sounds a bit dangerous to be enabled by default according
> to the config help text.
The help is indeed really scary :-)
Tony,
Do we want to keep it by default? Or should we fix the kconfig help?
Regards
Benoit
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-13 13:34 ` Cousson, Benoit
@ 2011-12-13 22:38 ` Tony Lindgren
2011-12-15 16:28 ` Cousson, Benoit
2011-12-16 15:25 ` Cousson, Benoit
0 siblings, 2 replies; 9+ messages in thread
From: Tony Lindgren @ 2011-12-13 22:38 UTC (permalink / raw)
To: linux-arm-kernel
* Cousson, Benoit <b-cousson@ti.com> [111213 05:02]:
> On 12/13/2011 2:27 PM, Tomi Valkeinen wrote:
> >Hi,
> >
> >On Tue, 2011-12-06 at 17:49 +0100, Benoit Cousson wrote:
> >>devicetree will become the mandatory boot method for OMAP2+.
> >>In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
> >>select USE_OF by default for every OMAP2+ systems.
> >>Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
> >>boot loader to keep working properly.
> >
> >APPENDED_DTB sounds a bit dangerous to be enabled by default according
> >to the config help text.
>
> The help is indeed really scary :-)
Heh, but it's also true.
> Tony,
> Do we want to keep it by default? Or should we fix the kconfig help?
Let's just leave out those two from omap2plus_defconfig then.
Regards,
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-13 22:38 ` Tony Lindgren
@ 2011-12-15 16:28 ` Cousson, Benoit
2011-12-16 15:25 ` Cousson, Benoit
1 sibling, 0 replies; 9+ messages in thread
From: Cousson, Benoit @ 2011-12-15 16:28 UTC (permalink / raw)
To: linux-arm-kernel
On 12/13/2011 11:38 PM, Tony Lindgren wrote:
> * Cousson, Benoit<b-cousson@ti.com> [111213 05:02]:
>> On 12/13/2011 2:27 PM, Tomi Valkeinen wrote:
>>> Hi,
>>>
>>> On Tue, 2011-12-06 at 17:49 +0100, Benoit Cousson wrote:
>>>> devicetree will become the mandatory boot method for OMAP2+.
>>>> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
>>>> select USE_OF by default for every OMAP2+ systems.
>>>> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
>>>> boot loader to keep working properly.
>>>
>>> APPENDED_DTB sounds a bit dangerous to be enabled by default according
>>> to the config help text.
>>
>> The help is indeed really scary :-)
>
> Heh, but it's also true.
>
>> Tony,
>> Do we want to keep it by default? Or should we fix the kconfig help?
>
> Let's just leave out those two from omap2plus_defconfig then.
OK. I'll do that.
Benoit
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-13 22:38 ` Tony Lindgren
2011-12-15 16:28 ` Cousson, Benoit
@ 2011-12-16 15:25 ` Cousson, Benoit
2011-12-17 0:20 ` Tony Lindgren
1 sibling, 1 reply; 9+ messages in thread
From: Cousson, Benoit @ 2011-12-16 15:25 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tony,
On 12/13/2011 11:38 PM, Tony Lindgren wrote:
> * Cousson, Benoit<b-cousson@ti.com> [111213 05:02]:
>> On 12/13/2011 2:27 PM, Tomi Valkeinen wrote:
>>> Hi,
>>>
>>> On Tue, 2011-12-06 at 17:49 +0100, Benoit Cousson wrote:
>>>> devicetree will become the mandatory boot method for OMAP2+.
>>>> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
>>>> select USE_OF by default for every OMAP2+ systems.
>>>> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
>>>> boot loader to keep working properly.
>>>
>>> APPENDED_DTB sounds a bit dangerous to be enabled by default according
>>> to the config help text.
>>
>> The help is indeed really scary :-)
>
> Heh, but it's also true.
>
>> Tony,
>> Do we want to keep it by default? Or should we fix the kconfig help?
>
> Let's just leave out those two from omap2plus_defconfig then.
Here is the updated version.
Just let me know if you'd like to get the full series re-posted.
Thanks,
Benoit
---
>From b33d4be0213ab0c630b87bd3df77035cbb109cd0 Mon Sep 17 00:00:00 2001
From: Benoit Cousson <b-cousson@ti.com>
Date: Thu, 1 Dec 2011 10:21:16 +0100
Subject: [PATCH] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
devicetree will become the mandatory boot method for OMAP2+.
In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
select USE_OF by default for every OMAP2+ systems.
Enable PROC_DEVICETREE as well.
Signed-off-by: Benoit Cousson <b-cousson@ti.com>
Cc: Tony Lindgren <tony@atomide.com>
---
arch/arm/mach-omap2/Kconfig | 1 -
arch/arm/plat-omap/Kconfig | 2 ++
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index b662513..bdd5b68 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -111,7 +111,6 @@ comment "OMAP Board Type"
config MACH_OMAP_GENERIC
bool "Generic OMAP2+ board"
depends on ARCH_OMAP2PLUS
- select USE_OF
default y
help
Support for generic TI OMAP2+ boards using Flattened Device Tree.
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
index aa59f42..734009a 100644
--- a/arch/arm/plat-omap/Kconfig
+++ b/arch/arm/plat-omap/Kconfig
@@ -24,6 +24,8 @@ config ARCH_OMAP2PLUS
select CLKDEV_LOOKUP
select GENERIC_IRQ_CHIP
select OMAP_DM_TIMER
+ select USE_OF
+ select PROC_DEVICETREE
help
"Systems based on OMAP2, OMAP3 or OMAP4"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-16 15:25 ` Cousson, Benoit
@ 2011-12-17 0:20 ` Tony Lindgren
0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2011-12-17 0:20 UTC (permalink / raw)
To: linux-arm-kernel
* Cousson, Benoit <b-cousson@ti.com> [111216 06:53]:
> Hi Tony,
>
> On 12/13/2011 11:38 PM, Tony Lindgren wrote:
> > * Cousson, Benoit<b-cousson@ti.com> [111213 05:02]:
> >> On 12/13/2011 2:27 PM, Tomi Valkeinen wrote:
> >>> Hi,
> >>>
> >>> On Tue, 2011-12-06 at 17:49 +0100, Benoit Cousson wrote:
> >>>> devicetree will become the mandatory boot method for OMAP2+.
> >>>> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
> >>>> select USE_OF by default for every OMAP2+ systems.
> >>>> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
> >>>> boot loader to keep working properly.
> >>>
> >>> APPENDED_DTB sounds a bit dangerous to be enabled by default according
> >>> to the config help text.
> >>
> >> The help is indeed really scary :-)
> >
> > Heh, but it's also true.
> >
> >> Tony,
> >> Do we want to keep it by default? Or should we fix the kconfig help?
> >
> > Let's just leave out those two from omap2plus_defconfig then.
>
> Here is the updated version.
> Just let me know if you'd like to get the full series re-posted.
Thanks applying into dt branch. No need to repost this series.
Regards,
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2011-12-06 16:49 [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems Benoit Cousson
2011-12-13 13:27 ` Tomi Valkeinen
@ 2012-01-04 20:11 ` Grant Likely
2012-01-06 16:37 ` Cousson, Benoit
1 sibling, 1 reply; 9+ messages in thread
From: Grant Likely @ 2012-01-04 20:11 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Dec 6, 2011 at 9:49 AM, Benoit Cousson <b-cousson@ti.com> wrote:
> devicetree will become the mandatory boot method for OMAP2+.
> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
> select USE_OF by default for every OMAP2+ systems.
> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
> boot loader to keep working properly.
>
> Enable PROC_DEVICETREE as well.
>
> Signed-off-by: Benoit Cousson <b-cousson@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> ?arch/arm/mach-omap2/Kconfig | ? ?1 -
> ?arch/arm/plat-omap/Kconfig ?| ? ?4 ++++
> ?2 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index e1293aa..056a812 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -109,7 +109,6 @@ comment "OMAP Board Type"
> ?config MACH_OMAP_GENERIC
> ? ? ? ?bool "Generic OMAP2+ board"
> ? ? ? ?depends on ARCH_OMAP2PLUS
> - ? ? ? select USE_OF
> ? ? ? ?default y
> ? ? ? ?help
> ? ? ? ? ?Support for generic TI OMAP2+ boards using Flattened Device Tree.
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index aa59f42..74f41dc 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -24,6 +24,10 @@ config ARCH_OMAP2PLUS
> ? ? ? ?select CLKDEV_LOOKUP
> ? ? ? ?select GENERIC_IRQ_CHIP
> ? ? ? ?select OMAP_DM_TIMER
> + ? ? ? select USE_OF
> + ? ? ? select ARM_APPENDED_DTB
> + ? ? ? select ARM_ATAG_DTB_COMPAT
> + ? ? ? select PROC_DEVICETREE
> ? ? ? ?help
> ? ? ? ? ?"Systems based on OMAP2, OMAP3 or OMAP4"
>
> --
> 1.7.0.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems
2012-01-04 20:11 ` Grant Likely
@ 2012-01-06 16:37 ` Cousson, Benoit
0 siblings, 0 replies; 9+ messages in thread
From: Cousson, Benoit @ 2012-01-06 16:37 UTC (permalink / raw)
To: linux-arm-kernel
On 1/4/2012 9:11 PM, Grant Likely wrote:
> On Tue, Dec 6, 2011 at 9:49 AM, Benoit Cousson<b-cousson@ti.com> wrote:
>> devicetree will become the mandatory boot method for OMAP2+.
>> In order to avoid cluttering the OMAP code with #ifdef CONFIG_OF,
>> select USE_OF by default for every OMAP2+ systems.
>> Select as well the APPENDED_DTB and ATAG_DTB_COMPAT to allow legacy
>> boot loader to keep working properly.
>>
>> Enable PROC_DEVICETREE as well.
>>
>> Signed-off-by: Benoit Cousson<b-cousson@ti.com>
>> Cc: Tony Lindgren<tony@atomide.com>
>
> Acked-by: Grant Likely<grant.likely@secretlab.ca>
Thanks for the reviews.
Benoit
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-01-06 16:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-06 16:49 [PATCH 1/3] ARM: OMAP2+: kconfig: Enable devicetree by default for OMAP2+ systems Benoit Cousson
2011-12-13 13:27 ` Tomi Valkeinen
2011-12-13 13:34 ` Cousson, Benoit
2011-12-13 22:38 ` Tony Lindgren
2011-12-15 16:28 ` Cousson, Benoit
2011-12-16 15:25 ` Cousson, Benoit
2011-12-17 0:20 ` Tony Lindgren
2012-01-04 20:11 ` Grant Likely
2012-01-06 16:37 ` Cousson, Benoit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).