From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Wed, 14 Dec 2011 14:15:22 +0100 Subject: [PATCH v3] arm: omap3evm: Add support for an MT9M032 based camera board. In-Reply-To: <4EE86CF7.1010002@compulab.co.il> References: <1323825934-13320-1-git-send-email-martin@neutronstar.dyndns.org> <4EE86CF7.1010002@compulab.co.il> Message-ID: <201112141415.23885.laurent.pinchart@ideasonboard.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Igor, On Wednesday 14 December 2011 10:31:35 Igor Grinberg wrote: > On 12/14/11 03:25, Martin Hostettler wrote: > > Adds board support for an MT9M032 based camera to omap3evm. > > > > Signed-off-by: Martin Hostettler [snip] > > diff --git a/arch/arm/mach-omap2/board-omap3evm-camera.c > > b/arch/arm/mach-omap2/board-omap3evm-camera.c new file mode 100644 > > index 0000000..bffd5b8 > > --- /dev/null > > +++ b/arch/arm/mach-omap2/board-omap3evm-camera.c > > @@ -0,0 +1,155 @@ [snip] > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include "mux.h" > > + > > +#include "../../../drivers/media/video/omap3isp/isp.h" > > Laurent, > In one of the previous reviews, you stated: > "I'll probably split it and move the part required by board files to > include/media/omap3isp.h". > Is there any progress on that? Yes, it has been half-fixed in mainline. Half only because all the structures and macros that should be used by board code are now in , but some boards need to access OMAP3 ISP internals from board code, which still requires drivers/media/video/omap3isp/isp.h. This will eventually be fixed, when the generic struct clk object will be available. After a quick look at this patch it seems that should be enough here. > > +#include "media/mt9m032.h" And this should be > > +#include "devices.h" -- Regards, Laurent Pinchart