From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-next] make s5p64x0_defconfig build error
Date: Wed, 14 Dec 2011 19:12:05 +0000 [thread overview]
Message-ID: <20111214191205.GF14542@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20111214123244.GE7122@mudshark.cambridge.arm.com>
On Wed, Dec 14, 2011 at 12:32:44PM +0000, Will Deacon wrote:
> On Wed, Dec 14, 2011 at 04:57:10AM +0000, Axel Lin wrote:
> > I got below build error on linux-next 20111213.
> >
> > CC arch/arm/kernel/process.o
> > In file included from arch/arm/mach-s5p64x0/include/mach/system.h:16,
> > from arch/arm/kernel/process.c:64:
> > arch/arm/plat-samsung/include/plat/system-reset.h:19:2: error: #error Fix me up
> > make[1]: *** [arch/arm/kernel/process.o] Error 1
> > make: *** [arch/arm/kernel] Error 2
>
> The clue is in the commit message:
>
> commit d0f7e2beabe6a116152ccc31959b6654b6ef0071
> Author: Russell King <rmk+kernel@arm.linux.org.uk>
> Date: Tue Dec 6 12:57:02 2011 +0000
>
> ARM: restart: Temporary #error to persuade platform maintainers to take the restart changes seriously
>
> Force builds to fail to ensure that platform maintainers take the
> restart changes seriously, and sort out fixing their code before the
> next merge window.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Indeed, and note the date, and how long its taken for just one of the
platforms to be noticed.
It seems to me that no one really cares about whether six of the seven
platforms which have the #error build or don't build, so I really think
there's a simple solution to this at the next merge window - delete any
platform which hasn't _at_ _least_ responded with a proposed patch to
this.
The platform maintainers have had _enough_ notice of this - by not
responding, they're quite simply an obstacle to further consolidation,
and we're not going to go through months of waiting for their response
time and time again.
I've posted the patches to the mailing list, I've copied them asking
for help, I've chased them several times, and now they have a #error
to deal with. If none of this gets their attention (it seems it
doesn't), then frankly their platform is unmaintained, it will be
broken at the next merge window, and therefore _should_ be deleted.
So... unless things change, we can expect Gemini, almost all Samsung
stuff, shmobile, vt8500, and Telechips TCC8k to be at least broken at
the next merge window.
next prev parent reply other threads:[~2011-12-14 19:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 4:57 [linux-next] make s5p64x0_defconfig build error Axel Lin
2011-12-14 12:32 ` Will Deacon
2011-12-14 19:12 ` Russell King - ARM Linux [this message]
2011-12-14 20:45 ` Nicolas Pitre
2011-12-14 23:30 ` Denis Kuzmenko
2011-12-14 23:54 ` Russell King - ARM Linux
2011-12-14 23:33 ` Kukjin Kim
2011-12-14 23:54 ` Axel Lin
2011-12-15 8:09 ` Heiko Stübner
2011-12-15 5:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214191205.GF14542@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).