* Massive log spam loading modules on ARM after 3.2-rc5 (regression)
[not found] <20111214215133.GA7780@elliptictech.com>
@ 2011-12-15 8:02 ` Uwe Kleine-König
2011-12-15 8:31 ` Russell King - ARM Linux
2011-12-15 9:26 ` Uwe Kleine-König
2011-12-15 10:41 ` Uwe Kleine-König
2 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2011-12-15 8:02 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 14, 2011 at 04:51:33PM -0500, Nick Bowler wrote:
> Hi folks,
>
> With latest Linus' master, I'm faced with massive log spam on our ARM
> Versatile Express platform when using modules. Here's an example:
>
> # modprobe sp805-wdt
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> sp805-wdt mb:wdt: registration successful
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
>
> The message only seem to get printed at module load time. Other than
> the noise, things _seem_ to be working. Nevertheless, it's a regression
> introduced after 3.2-rc5 by the following commit:
>
> de66a979012dbc66b1ec0125795a3f79ee667b8a is the first bad commit
> commit de66a979012dbc66b1ec0125795a3f79ee667b8a
> Author: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Date: Mon Dec 5 09:39:59 2011 +0100
>
> ARM: 7187/1: fix unwinding for XIP kernels
>
> The linker places the unwind tables in readonly sections. So when using
> an XIP kernel these are located in ROM and cannot be modified.
> For that reason the current approach to convert the relative offsets in
> the unwind index to absolute addresses early in the boot process doesn't
> work with XIP.
>
> The offsets in the unwind index section are signed 31 bit numbers and
> the structs are sorted by this offset. So it first has offsets between
> 0x40000000 and 0x7fffffff (i.e. the negative offsets) and then offsets
> between 0x00000000 and 0x3fffffff. When seperating these two blocks the
> numbers are sorted even when interpreting the offsets as unsigned longs.
>
> So determine the first non-negative entry once and track that using the
> new origin pointer. The actual bisection can then use a plain unsigned
> long comparison. The only thing that makes the new bisection more
> complicated is that the offsets are relative to their position in the
> index section, so the key to search needs to be adapted accordingly in
> each step.
>
> Moreover several consts are added to catch future writes and rename the
> member "addr" of struct unwind_idx to "addr_offset" to better match the
> new semantic. (This has the additional benefit of breaking eventual
> users at compile time to make them aware of the change.)
>
> In my tests the new algorithm was a tad faster than the original and has
> the additional upside of not needing the initial conversion and so saves
> some boot time and it's possible to unwind even earlier.
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> :040000 040000 9c4363228515808d71dac84a4a16e0aa0cf4ceaa 65b80d4e51fabf0a3142a880be795f4b38f4d9fe M arch
>
> I am *not* using XIP. Reverting this commit resolves the issue.
I'd say revert that change for now, I'll take a look. (IMHO this is
merge window material even though it has "fix" in the title. The
addressed problem is only relevant on XIP (which isn't used much AFAIK)
and is broken since 2.6.30-rc1~636^2~52^2~18 when unwinding was
introduced.)
> Let me know if you need any more info,
I know where to look, I'll address you via private mail if I need some
more data.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread* Massive log spam loading modules on ARM after 3.2-rc5 (regression)
2011-12-15 8:02 ` Massive log spam loading modules on ARM after 3.2-rc5 (regression) Uwe Kleine-König
@ 2011-12-15 8:31 ` Russell King - ARM Linux
0 siblings, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2011-12-15 8:31 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 15, 2011 at 09:02:13AM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Dec 14, 2011 at 04:51:33PM -0500, Nick Bowler wrote:
> > The message only seem to get printed at module load time. Other than
> > the noise, things _seem_ to be working. Nevertheless, it's a regression
> > introduced after 3.2-rc5 by the following commit:
> >
> > de66a979012dbc66b1ec0125795a3f79ee667b8a is the first bad commit
> > commit de66a979012dbc66b1ec0125795a3f79ee667b8a
> > Author: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > Date: Mon Dec 5 09:39:59 2011 +0100
> >
> > ARM: 7187/1: fix unwinding for XIP kernels
> >
> > The linker places the unwind tables in readonly sections. So when using
> > an XIP kernel these are located in ROM and cannot be modified.
> > For that reason the current approach to convert the relative offsets in
> > the unwind index to absolute addresses early in the boot process doesn't
> > work with XIP.
> >
> > The offsets in the unwind index section are signed 31 bit numbers and
> > the structs are sorted by this offset. So it first has offsets between
> > 0x40000000 and 0x7fffffff (i.e. the negative offsets) and then offsets
> > between 0x00000000 and 0x3fffffff. When seperating these two blocks the
> > numbers are sorted even when interpreting the offsets as unsigned longs.
> >
> > So determine the first non-negative entry once and track that using the
> > new origin pointer. The actual bisection can then use a plain unsigned
> > long comparison. The only thing that makes the new bisection more
> > complicated is that the offsets are relative to their position in the
> > index section, so the key to search needs to be adapted accordingly in
> > each step.
> >
> > Moreover several consts are added to catch future writes and rename the
> > member "addr" of struct unwind_idx to "addr_offset" to better match the
> > new semantic. (This has the additional benefit of breaking eventual
> > users at compile time to make them aware of the change.)
> >
> > In my tests the new algorithm was a tad faster than the original and has
> > the additional upside of not needing the initial conversion and so saves
> > some boot time and it's possible to unwind even earlier.
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > Acked-by: Nicolas Pitre <nico@fluxnic.net>
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> >
> > :040000 040000 9c4363228515808d71dac84a4a16e0aa0cf4ceaa 65b80d4e51fabf0a3142a880be795f4b38f4d9fe M arch
> >
> > I am *not* using XIP. Reverting this commit resolves the issue.
> I'd say revert that change for now, I'll take a look. (IMHO this is
> merge window material even though it has "fix" in the title. The
> addressed problem is only relevant on XIP (which isn't used much AFAIK)
> and is broken since 2.6.30-rc1~636^2~52^2~18 when unwinding was
> introduced.)
For christ sake Uwe, stop being an idiot. If that's the case then
YOU NEED TO SAY which kernel you want the patch applied to, and not
leave it up to chance. Nothing in that says "this should not go
into -rc".
And wtf wasn't it tested with modules?
Congratulations, your incompetence will now have consequences. I'm
*not* going to apply any patch from you in future for -rc without
there being _several_ tested-by's from various people. So you're
going to find it harder to get patches in.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Massive log spam loading modules on ARM after 3.2-rc5 (regression)
[not found] <20111214215133.GA7780@elliptictech.com>
2011-12-15 8:02 ` Massive log spam loading modules on ARM after 3.2-rc5 (regression) Uwe Kleine-König
@ 2011-12-15 9:26 ` Uwe Kleine-König
2011-12-15 9:47 ` Russell King - ARM Linux
2011-12-15 10:41 ` Uwe Kleine-König
2 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2011-12-15 9:26 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 14, 2011 at 04:51:33PM -0500, Nick Bowler wrote:
> Hi folks,
>
> With latest Linus' master, I'm faced with massive log spam on our ARM
> Versatile Express platform when using modules. Here's an example:
>
> # modprobe sp805-wdt
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> sp805-wdt mb:wdt: registration successful
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
> unwind: Unknown symbol address 7f802009
> unwind: Index not found 7f802009
>
> The message only seem to get printed at module load time. Other than
> the noise, things _seem_ to be working. Nevertheless, it's a regression
> introduced after 3.2-rc5 by the following commit:
>
> de66a979012dbc66b1ec0125795a3f79ee667b8a is the first bad commit
> commit de66a979012dbc66b1ec0125795a3f79ee667b8a
> Author: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Date: Mon Dec 5 09:39:59 2011 +0100
>
> ARM: 7187/1: fix unwinding for XIP kernels
>
> The linker places the unwind tables in readonly sections. So when using
> an XIP kernel these are located in ROM and cannot be modified.
> For that reason the current approach to convert the relative offsets in
> the unwind index to absolute addresses early in the boot process doesn't
> work with XIP.
>
> The offsets in the unwind index section are signed 31 bit numbers and
> the structs are sorted by this offset. So it first has offsets between
> 0x40000000 and 0x7fffffff (i.e. the negative offsets) and then offsets
> between 0x00000000 and 0x3fffffff. When seperating these two blocks the
> numbers are sorted even when interpreting the offsets as unsigned longs.
>
> So determine the first non-negative entry once and track that using the
> new origin pointer. The actual bisection can then use a plain unsigned
> long comparison. The only thing that makes the new bisection more
> complicated is that the offsets are relative to their position in the
> index section, so the key to search needs to be adapted accordingly in
> each step.
>
> Moreover several consts are added to catch future writes and rename the
> member "addr" of struct unwind_idx to "addr_offset" to better match the
> new semantic. (This has the additional benefit of breaking eventual
> users at compile time to make them aware of the change.)
>
> In my tests the new algorithm was a tad faster than the original and has
> the additional upside of not needing the initial conversion and so saves
> some boot time and it's possible to unwind even earlier.
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> Acked-by: Nicolas Pitre <nico@fluxnic.net>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> :040000 040000 9c4363228515808d71dac84a4a16e0aa0cf4ceaa 65b80d4e51fabf0a3142a880be795f4b38f4d9fe M arch
>
> I am *not* using XIP. Reverting this commit resolves the issue.
>
> Let me know if you need any more info,
Can you provide me your .config please? I cannot reproduce your problems
with modprobe on an i.MX28 based tx28 machine.
Russell, maybe this makes you a bit less annoyed?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread* Massive log spam loading modules on ARM after 3.2-rc5 (regression)
2011-12-15 9:26 ` Uwe Kleine-König
@ 2011-12-15 9:47 ` Russell King - ARM Linux
2011-12-15 12:58 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2011-12-15 9:47 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Dec 15, 2011 at 10:26:33AM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Dec 14, 2011 at 04:51:33PM -0500, Nick Bowler wrote:
> > The message only seem to get printed at module load time. Other than
> > the noise, things _seem_ to be working. Nevertheless, it's a regression
> > introduced after 3.2-rc5 by the following commit:
> >
> > de66a979012dbc66b1ec0125795a3f79ee667b8a is the first bad commit
> > commit de66a979012dbc66b1ec0125795a3f79ee667b8a
> > Author: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > Date: Mon Dec 5 09:39:59 2011 +0100
> >
> > ARM: 7187/1: fix unwinding for XIP kernels
> >
> > The linker places the unwind tables in readonly sections. So when using
> > an XIP kernel these are located in ROM and cannot be modified.
> > For that reason the current approach to convert the relative offsets in
> > the unwind index to absolute addresses early in the boot process doesn't
> > work with XIP.
> >
> > The offsets in the unwind index section are signed 31 bit numbers and
> > the structs are sorted by this offset. So it first has offsets between
> > 0x40000000 and 0x7fffffff (i.e. the negative offsets) and then offsets
> > between 0x00000000 and 0x3fffffff. When seperating these two blocks the
> > numbers are sorted even when interpreting the offsets as unsigned longs.
> >
> > So determine the first non-negative entry once and track that using the
> > new origin pointer. The actual bisection can then use a plain unsigned
> > long comparison. The only thing that makes the new bisection more
> > complicated is that the offsets are relative to their position in the
> > index section, so the key to search needs to be adapted accordingly in
> > each step.
> >
> > Moreover several consts are added to catch future writes and rename the
> > member "addr" of struct unwind_idx to "addr_offset" to better match the
> > new semantic. (This has the additional benefit of breaking eventual
> > users at compile time to make them aware of the change.)
> >
> > In my tests the new algorithm was a tad faster than the original and has
> > the additional upside of not needing the initial conversion and so saves
> > some boot time and it's possible to unwind even earlier.
> >
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > Acked-by: Nicolas Pitre <nico@fluxnic.net>
> > Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> >
> > :040000 040000 9c4363228515808d71dac84a4a16e0aa0cf4ceaa 65b80d4e51fabf0a3142a880be795f4b38f4d9fe M arch
> >
> > I am *not* using XIP. Reverting this commit resolves the issue.
> >
> > Let me know if you need any more info,
> Can you provide me your .config please? I cannot reproduce your problems
> with modprobe on an i.MX28 based tx28 machine.
>
> Russell, maybe this makes you a bit less annoyed?
Why should it?
1. Your change is totally unaffected by whether XIP is being used or not,
so this is irrelevant.
2. You plainly said in your previous message (and I quote) "IMHO this is
merge window material even though it has "fix" in the title.".
The fact of the matter is that you _never_ said that you didn't consider
your patch -rc material - and that alone is what I'm complaining at you
about. It is _YOUR_ responsibility to indicate where a patch should be
applied. You failed to do that.
Don't expect others to have a magical crystal ball to be able to see into
your mind to find out where you intended your patch to be applied. It
doesn't work like that. You have to state that - especially if it is a
'fix' patch but is _not_ supposed to go into -rc.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Massive log spam loading modules on ARM after 3.2-rc5 (regression)
2011-12-15 9:47 ` Russell King - ARM Linux
@ 2011-12-15 12:58 ` Uwe Kleine-König
0 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2011-12-15 12:58 UTC (permalink / raw)
To: linux-arm-kernel
Hello Russell,
On Thu, Dec 15, 2011 at 09:47:33AM +0000, Russell King - ARM Linux wrote:
> > Can you provide me your .config please? I cannot reproduce your problems
> > with modprobe on an i.MX28 based tx28 machine.
> >
> > Russell, maybe this makes you a bit less annoyed?
>
> Why should it?
If you consider my statement to relate to your "And wtf wasn't it
tested with modules?" it might convince you that my testing included
modules, too.
Assuming that the fix I send to Nick solves his problem, this problem
only affects the last function before and first function after the .idx
section and that only in approx. one out of two cases. (And additionally
for me the unwinder isn't used on modprobe.) So I still think my testing
was OK.
> 1. Your change is totally unaffected by whether XIP is being used or not,
> so this is irrelevant.
> 2. You plainly said in your previous message (and I quote) "IMHO this is
> merge window material even though it has "fix" in the title.".
>
> The fact of the matter is that you _never_ said that you didn't consider
> your patch -rc material - and that alone is what I'm complaining at you
> about. It is _YOUR_ responsibility to indicate where a patch should be
> applied. You failed to do that.
I don't think that it makes sense to continue arguing here. If you have
to name someone to Linus who is responsible for this regression, feel
free to say my name. (Ah, I see he's on Cc: ...)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Massive log spam loading modules on ARM after 3.2-rc5 (regression)
[not found] <20111214215133.GA7780@elliptictech.com>
2011-12-15 8:02 ` Massive log spam loading modules on ARM after 3.2-rc5 (regression) Uwe Kleine-König
2011-12-15 9:26 ` Uwe Kleine-König
@ 2011-12-15 10:41 ` Uwe Kleine-König
2 siblings, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2011-12-15 10:41 UTC (permalink / raw)
To: linux-arm-kernel
Hi Nick,
I found a problem, can you please try the following patch:
diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
index 3f03fe0..00df012 100644
--- a/arch/arm/kernel/unwind.c
+++ b/arch/arm/kernel/unwind.c
@@ -160,12 +160,12 @@ static const struct unwind_idx *unwind_find_origin(
const struct unwind_idx *start, const struct unwind_idx *stop)
{
pr_debug("%s(%p, %p)\n", __func__, start, stop);
- while (start < stop - 1) {
+ while (start < stop) {
const struct unwind_idx *mid = start + ((stop - start) >> 1);
if (mid->addr_offset >= 0x40000000)
/* negative offset */
- start = mid;
+ start = mid + 1;
else
/* positive offset */
stop = mid;
I'll think a bit more about that during lunch and come up with a proper
commit log if it works for you.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply related [flat|nested] 6+ messages in thread