linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: add device tree blobs to .gitignore
@ 2011-12-13 20:36 Uwe Kleine-König
  2011-12-15  2:25 ` Shawn Guo
  2011-12-15 14:47 ` Dave Martin
  0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2011-12-13 20:36 UTC (permalink / raw)
  To: linux-arm-kernel

*.dtb files are a build result and so should be ignored.

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boot/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
index ce1c5ff..3c79f85 100644
--- a/arch/arm/boot/.gitignore
+++ b/arch/arm/boot/.gitignore
@@ -3,3 +3,4 @@ zImage
 xipImage
 bootpImage
 uImage
+*.dtb
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] ARM: add device tree blobs to .gitignore
  2011-12-13 20:36 [PATCH] ARM: add device tree blobs to .gitignore Uwe Kleine-König
@ 2011-12-15  2:25 ` Shawn Guo
  2011-12-15 14:47 ` Dave Martin
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2011-12-15  2:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Dec 13, 2011 at 09:36:52PM +0100, Uwe Kleine-K?nig wrote:
> *.dtb files are a build result and so should be ignored.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---

Acked-by: Shawn Guo <shawn.guo@linaro.org>

-- 
Regards,
Shawn

>  arch/arm/boot/.gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore
> index ce1c5ff..3c79f85 100644
> --- a/arch/arm/boot/.gitignore
> +++ b/arch/arm/boot/.gitignore
> @@ -3,3 +3,4 @@ zImage
>  xipImage
>  bootpImage
>  uImage
> +*.dtb
> -- 
> 1.7.7.3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: add device tree blobs to .gitignore
  2011-12-13 20:36 [PATCH] ARM: add device tree blobs to .gitignore Uwe Kleine-König
  2011-12-15  2:25 ` Shawn Guo
@ 2011-12-15 14:47 ` Dave Martin
  2011-12-15 21:30   ` Uwe Kleine-König
  1 sibling, 1 reply; 4+ messages in thread
From: Dave Martin @ 2011-12-15 14:47 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Dec 13, 2011 at 09:36:52PM +0100, Uwe Kleine-K??nig wrote:
> *.dtb files are a build result and so should be ignored.
> 
> Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>

Should this actually be global?

It looks like at least powerpc, microblaze and openrisc may generate
.dtbs and I don't see any local .gitignore entries for those.

Since the dtc tool itself is global (i.e., in an arch-independent
scripts dir instead of somewhere arch-specific), it could be argued that
other related stuff should be global too.

Cheers
---Dave

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] ARM: add device tree blobs to .gitignore
  2011-12-15 14:47 ` Dave Martin
@ 2011-12-15 21:30   ` Uwe Kleine-König
  0 siblings, 0 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2011-12-15 21:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Dec 15, 2011 at 02:47:57PM +0000, Dave Martin wrote:
> On Tue, Dec 13, 2011 at 09:36:52PM +0100, Uwe Kleine-K??nig wrote:
> > *.dtb files are a build result and so should be ignored.
> > 
> > Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de>
> 
> Should this actually be global?
> 
> It looks like at least powerpc, microblaze and openrisc may generate
> .dtbs and I don't see any local .gitignore entries for those.
> 
> Since the dtc tool itself is global (i.e., in an arch-independent
> scripts dir instead of somewhere arch-specific), it could be argued that
> other related stuff should be global too.
hmm, I'm not convinced. The build system puts ARM dtb images only in
arch/arm/boot, so IMHO they should only be ignored there. If the other
arch don't .gitignore the dtb files they should get a specific entry,
too.

Having said that, adding a / to my patch would be the right thing to do.
(i.e.

	+/*.dtb

) The other entries could get a slash, too. Maybe a bit over engineered.

Best regards
Uwe


-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-12-15 21:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-13 20:36 [PATCH] ARM: add device tree blobs to .gitignore Uwe Kleine-König
2011-12-15  2:25 ` Shawn Guo
2011-12-15 14:47 ` Dave Martin
2011-12-15 21:30   ` Uwe Kleine-König

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).