From: kirill@shutemov.name (Kirill A. Shutemov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] [RESEND] Handle instruction cache maintenance fault properly
Date: Fri, 16 Dec 2011 04:22:05 +0200 [thread overview]
Message-ID: <20111216022205.GA28787@shutemov.name> (raw)
In-Reply-To: <20111215215649.GJ24496@pengutronix.de>
On Thu, Dec 15, 2011 at 10:56:49PM +0100, Uwe Kleine-K?nig wrote:
> Hello,
>
> On Tue, May 11, 2010 at 01:33:14PM +0300, Kirill A. Shutemov wrote:
> > Between "clean D line..." and "invalidate I line" operations in
> > v7_coherent_user_range(), the memory page may get swapped out.
> > And the fault on "invalidate I line" could not be properly handled
> > causing the oops.
> >
> > In ARMv6 "external abort on linefetch" replaced by "instruction cache
> > maintenance fault". Let's handle it as translation fault. It fixes the
> > issue.
> >
> > I'm not sure if it's reasonable to check arch version in run-time.
> > Let's do it in compile time for now.
> >
> > Signed-off-by: Siarhei Siamashka <siarhei.siamashka@nokia.com>
> > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> I found this patch in Catalin's stack that I picked up to get support
> for Cortex-M3. Is this still relevant?
It's in upstream. See 8c0b742.
>
> Best regards
> Uwe
>
> > Sorry for resend. I've made mistake in maillist address.
> >
> > ---
> > arch/arm/mm/fault.c | 5 +++++
> > 1 files changed, 5 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c
> > index 9d40c34..7f193ea 100644
> > --- a/arch/arm/mm/fault.c
> > +++ b/arch/arm/mm/fault.c
> > @@ -463,7 +463,12 @@ static struct fsr_info {
> > { do_bad, SIGILL, BUS_ADRALN, "alignment exception" },
> > { do_bad, SIGKILL, 0, "terminal exception" },
> > { do_bad, SIGILL, BUS_ADRALN, "alignment exception" },
> > +/* Do we need runtime check ? */
> > +#if __LINUX_ARM_ARCH__ < 6
> > { do_bad, SIGBUS, 0, "external abort on linefetch" },
> > +#else
> > + { do_translation_fault, SIGSEGV, SEGV_MAPPER, "I-cache maintenance
> > fault" },
> > +#endif
> > { do_translation_fault, SIGSEGV, SEGV_MAPERR, "section translation
> > fault" },
> > { do_bad, SIGBUS, 0, "external abort on linefetch" },
> > { do_page_fault, SIGSEGV, SEGV_MAPERR, "page translation fault" },
> > --
> > 1.7.0.4
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
> --
> Pengutronix e.K. | Uwe Kleine-K?nig |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
--
Kirill A. Shutemov
next prev parent reply other threads:[~2011-12-16 2:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 10:33 [PATCH v2] [RESEND] Handle instruction cache maintenance fault properly Kirill A. Shutemov
2010-05-12 11:01 ` Catalin Marinas
2010-05-14 13:29 ` Catalin Marinas
2011-12-15 21:56 ` Uwe Kleine-König
2011-12-16 2:22 ` Kirill A. Shutemov [this message]
2011-12-16 10:01 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216022205.GA28787@shutemov.name \
--to=kirill@shutemov.name \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).