From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] DaVinci cleanup for v3.3
Date: Fri, 16 Dec 2011 14:28:03 +0000 [thread overview]
Message-ID: <201112161428.03412.arnd@arndb.de> (raw)
In-Reply-To: <DF0F476B391FA8409C78302C7BA518B6048974@DBDE01.ent.ti.com>
On Wednesday 14 December 2011, Nori, Sekhar wrote:
> I have this lone patch queued for DaVinci clean-up so far.
> Can you please pull this?
>
> The following changes since commit caca6a03d365883564885f2c1da3e88dcf65d139:
> Linus Torvalds (1):
> Linux 3.2-rc3
>
> are available in the git repository at:
>
> git://gitorious.org/linux-davinci/linux-davinci.git v3.3/cleanup
>
Pulled into next/cleanups, but not happy about the patch.
While the patch is a move in the right direction, it is not sufficient for
what you intend with it:
Author: Manjunath Hadli <manjunath.hadli@ti.com>
Date: Sat Nov 12 20:36:02 2011 +0530
ARM: davinci: vpif: move code to driver core header from platform
Move vpif related definitions for capture and display drivers
from dm646x platform header file to vpif_types.h inside
the driver as these definitions are related to driver code
rather than the platform or board.
This enables reusing this IP across platforms.
If you really want to use the same IP on future platforms, the correct
approach would be to get rid of the requirement for having platform-
specific callbacks and setup data, and replace it all with device tree
based probing. I can understand that you consider mach-davinci legacy
code and don't want to rework it in significant ways, but if a driver
that is used in there is not legacy code, it should be updated to the
modern ways of doing this.
Arnd
next prev parent reply other threads:[~2011-12-16 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 18:09 [GIT PULL] DaVinci cleanup for v3.3 Nori, Sekhar
2011-12-16 14:28 ` Arnd Bergmann [this message]
2011-12-19 8:12 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112161428.03412.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).