From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/7] s3c-hsudc: regulator handling and a lot of fixes
Date: Sat, 17 Dec 2011 20:23:04 +0100 [thread overview]
Message-ID: <201112172023.05519.heiko@sntech.de> (raw)
In his response to the first submission Felipe Balbi asked to also move
the driver to the new udc_start and udc_stop functions and to make an
effort to reduce dependencies on archictecture code.
The first patch reduces the number of arch dependencies by one by moving
the platform data struct to a header unter include/linux/usb.
The third patch adds a remove function, that was missing until now.
The fifth and sixt patches implement the move to udc_start / udc_stop
And the last patch finally allows the s3c-hsudc driver to control its
supplying regulators as intended in the first place.
The regulator calls can use the regulators unconditionally and let
necessary "stubbing and mapping" happen through the regulator framework,
according to for example
http://marc.info/?l=linux-netdev&m=131914562120725&w=2
meaning there is no need to gracefully fail if a regulator is not present.
Each patch was compile-tested individually, the series applies cleanly
against linux-next from 2011-12-16.
Real-life testing happened on S3C2416 hardware including adding and
removing of gadgets and unloading and later on reloading the s3c_hsudc
module.
Heiko Stuebner (7):
s3c-hsudc: move platform_data struct to global header
s3c-hsudc: add __devinit to probe function
s3c-hsudc: add a remove function
s3c-hsudc: add missing otg_put_transceiver in probe
s3c-hsudc: move device registration to probe and remove
s3c-hsudc: use udc_start and udc_stop functions
s3c-hsudc: Add regulator handling
arch/arm/mach-s3c2416/mach-smdk2416.c | 1 +
arch/arm/plat-samsung/devs.c | 1 +
arch/arm/plat-samsung/include/plat/udc.h | 15 +---
drivers/usb/gadget/s3c-hsudc.c | 142 +++++++++++++++++++++---------
include/linux/usb/s3c-hsudc.h | 34 +++++++
5 files changed, 136 insertions(+), 57 deletions(-)
create mode 100644 include/linux/usb/s3c-hsudc.h
--
1.7.2.3
next reply other threads:[~2011-12-17 19:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 19:23 Heiko Stübner [this message]
2011-12-17 19:24 ` [PATCH 1/7] s3c-hsudc: move platform_data struct to global header Heiko Stübner
2011-12-17 19:25 ` [PATCH 2/7] s3c-hsudc: add __devinit to probe function Heiko Stübner
2011-12-17 19:26 ` [PATCH 3/7] s3c-hsudc: add a remove function Heiko Stübner
2011-12-18 8:03 ` Russell King - ARM Linux
2011-12-18 8:10 ` Russell King - ARM Linux
2011-12-18 9:42 ` Heiko Stübner
2011-12-18 13:44 ` Heiko Stübner
2011-12-18 14:43 ` Russell King - ARM Linux
2011-12-18 18:50 ` Heiko Stübner
2011-12-18 19:01 ` Russell King - ARM Linux
2011-12-18 19:33 ` Heiko Stübner
2011-12-18 19:45 ` Russell King - ARM Linux
2011-12-18 20:24 ` Heiko Stübner
2011-12-18 20:39 ` Russell King - ARM Linux
2011-12-18 20:46 ` Heiko Stübner
2011-12-18 21:37 ` Russell King - ARM Linux
2011-12-20 6:08 ` Greg KH
2011-12-20 6:07 ` Greg KH
2011-12-17 19:27 ` [PATCH 4/7] s3c-hsudc: add missing otg_put_transceiver in probe Heiko Stübner
2011-12-17 19:28 ` [PATCH 5/7] s3c-hsudc: move device registration to probe and remove Heiko Stübner
2011-12-18 8:09 ` Russell King - ARM Linux
2011-12-17 19:29 ` [PATCH 6/7] s3c-hsudc: use udc_start and udc_stop functions Heiko Stübner
2011-12-17 19:30 ` [PATCH 7/7] s3c-hsudc: Add regulator handling Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112172023.05519.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).