linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] mfd: mc13xxx: add device tree probe support
Date: Tue, 20 Dec 2011 14:35:58 +0000	[thread overview]
Message-ID: <20111220143558.GT2866@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111220135251.GB5129@S2101-09.ap.freescale.net>

On Tue, Dec 20, 2011 at 09:52:52PM +0800, Shawn Guo wrote:
> On Tue, Dec 20, 2011 at 11:25:11AM +0000, Mark Brown wrote:

> > Well, removing the random extra _s would be a big start (though I'd just
> > drop the chip name entirely from the name of the regulators since by the
> > time we're looking at the regulator we've already identified the chip)
> > and as I keep saying you need to document what the names mean - what are
> > the possible names and how do they map onto the hardware?

> I just came up with an idea which can totally avoid matching name.  It
> seems that we can identify a regulator using register plus enable bit,
> which is basically 'reg' and 'enable_bit' in 'mc13xxx_regulator'.  As
> these data must be coming from hardware manual, they should be stable
> enough for binding a regulator.  What do you think?

I don't know that that helps, register numbers and shifts aren't going
to do anything for legibility.  The problem with the names was that the
names chosen were poorly defined (why call DCDCn chipname__dcdcn?) and
not documented in the binding, not that they were names.

  reply	other threads:[~2011-12-20 14:35 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 15:15 [PATCH v3 0/3] Add device tree support for mc13892 regulator driver Shawn Guo
2011-12-12 15:15 ` [PATCH v3 1/3] mfd: mc13xxx: add device tree probe support Shawn Guo
2011-12-20  0:57   ` Mark Brown
2011-12-20  2:01     ` Shawn Guo
2011-12-20  1:59       ` Mark Brown
2011-12-20  3:03         ` Shawn Guo
2011-12-20 11:25           ` Mark Brown
2011-12-20 13:52             ` Shawn Guo
2011-12-20 14:35               ` Mark Brown [this message]
2011-12-20 15:31                 ` Shawn Guo
2011-12-20 23:25                   ` Mark Brown
2011-12-21  1:25                     ` Shawn Guo
2011-12-21  1:37                       ` Mark Brown
2011-12-21  2:12                         ` Shawn Guo
2011-12-12 15:15 ` [PATCH v3 2/3] regulator: mc13892: " Shawn Guo
2011-12-19 14:07   ` Shawn Guo
2011-12-20  0:54     ` Mark Brown
2011-12-20  1:37       ` Shawn Guo
2011-12-20  1:34         ` Mark Brown
2011-12-20  2:02           ` Shawn Guo
2011-12-12 15:15 ` [PATCH v3 3/3] arm/imx: add mc13892 support into imx51-babbage.dts Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111220143558.GT2866@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).