From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: new architecture for Energy Micro's EFM32 Cortex-M3 SoCs
Date: Wed, 21 Dec 2011 20:09:33 +0000 [thread overview]
Message-ID: <20111221200933.GA3117@page> (raw)
In-Reply-To: <20111221195602.GK2577@n2100.arm.linux.org.uk>
On Wed, Dec 21, 2011 at 07:56:02PM +0000, Russell King - ARM Linux wrote:
> On Wed, Dec 21, 2011 at 03:48:50PM +0000, Jamie Iles wrote:
> > > +#define __io(a) __typesafe_io(a)
> >
> > Do you support io ports on this platform? If not then perhaps select
> > NO_IPORT and define __io(a) to 0?
>
> Do not do that. Define NO_IOPORT and *do* *not* define __io() at all to
> make drivers which use PCI IO stuff fail at build time. Don't try to
> frig it into doing a NULL pointer deref.
Fair point. I said that because I remember that the 8250 driver uses
ioport accessors even for !HAVE_IOPORT and that some patches to remove
that were nacked, but I don't remember the details. But yes, not
defining __io would be much better!
Jamie
next prev parent reply other threads:[~2011-12-21 20:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 15:13 [RFC PATCH] ARM: new architecture for Energy Micro's EFM32 Cortex-M3 SoCs Uwe Kleine-König
2011-12-21 15:48 ` Jamie Iles
2011-12-21 16:44 ` Uwe Kleine-König
2011-12-21 19:56 ` Russell King - ARM Linux
2011-12-21 20:09 ` Jamie Iles [this message]
2011-12-21 20:36 ` Nicolas Pitre
2011-12-21 16:34 ` Arnd Bergmann
2011-12-21 19:54 ` Russell King - ARM Linux
2011-12-21 17:31 ` Ohad Ben-Cohen
2012-01-16 16:29 ` Uwe Kleine-König
2012-01-16 16:59 ` Ohad Ben-Cohen
2012-01-16 17:40 ` Russell King - ARM Linux
2012-01-16 18:10 ` Catalin Marinas
2012-01-16 19:06 ` Russell King - ARM Linux
2012-01-17 11:32 ` Catalin Marinas
2012-01-17 10:17 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111221200933.GA3117@page \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).