From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: max8925: fix enabled/disabled judgement mistake
Date: Thu, 22 Dec 2011 10:53:58 +0000 [thread overview]
Message-ID: <20111222105357.GC4546@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1324543892-32540-1-git-send-email-haojian.zhuang@marvell.com>
On Thu, Dec 22, 2011 at 04:51:32PM +0800, Haojian Zhuang wrote:
> From: Kevin Liu <kliu5@marvell.com>
>
> The judgement should depend on the power up/down sequence select.
> With flexible power sequence, regulator is always enabled after boot up.
> With i2c enabled, regulator enable/disable according to output enable bit.
I'm sorry but I'm having a hard time understanding what this changelog
means, please clarify.
> - return ret & (1 << info->enable_bit);
> + ldo_seq = (ret >> LDO_SEQ_SHIFT) & LDO_SEQ_MASK;
> + if (ldo_seq != LDO_SEQ_I2C_EN)
> + return 1 << info->enable_bit;
> + else
> + return ret & (1 << info->enable_bit);
Does this mean that the register for enabling and disabling the register
doesn't always work? If it does then doesn't that mean that the enable
and disable functions need to be updated as well to either put the
regulator into I2C mode or return an error when it isn't in I2C mode?
next prev parent reply other threads:[~2011-12-22 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 8:51 [PATCH] regulator: max8925: fix enabled/disabled judgement mistake Haojian Zhuang
2011-12-22 10:53 ` Mark Brown [this message]
2011-12-22 13:31 ` Haojian Zhuang
2011-12-22 13:44 ` Mark Brown
2011-12-22 14:22 ` Haojian Zhuang
2011-12-22 14:38 ` Mark Brown
2011-12-23 14:42 ` Haojian Zhuang
-- strict thread matches above, loose matches on Subject: below --
2012-01-04 7:12 Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222105357.GC4546@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).