From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: max8925: fix enabled/disabled judgement mistake
Date: Thu, 22 Dec 2011 13:44:15 +0000 [thread overview]
Message-ID: <20111222134415.GU4546@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAN1soZy+hgW2iaQad9gbis7bHLCnfQhMKx-JTJc1j2++eRrJyw@mail.gmail.com>
On Thu, Dec 22, 2011 at 09:31:22PM +0800, Haojian Zhuang wrote:
> On Thu, Dec 22, 2011 at 6:53 PM, Mark Brown
> > Does this mean that the register for enabling and disabling the register
> > doesn't always work? ?If it does then doesn't that mean that the enable
> > and disable functions need to be updated as well to either put the
> > regulator into I2C mode or return an error when it isn't in I2C mode?
> According to the logic in above, we need check both registers to figure out
> whether LDO is on or off.
> Return error if it isn't in I2C mode doesn't make sense. If sequence is in one
> of power-on sequence, the LDO is already ON by default.
I don't understand how your reply follows on from my comment here? If
the enable register doesn't control if the regulator is enabled and
disabled and it's always on then it seems fairly clear that the enable
and disable functions ought to know about this.
next prev parent reply other threads:[~2011-12-22 13:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 8:51 [PATCH] regulator: max8925: fix enabled/disabled judgement mistake Haojian Zhuang
2011-12-22 10:53 ` Mark Brown
2011-12-22 13:31 ` Haojian Zhuang
2011-12-22 13:44 ` Mark Brown [this message]
2011-12-22 14:22 ` Haojian Zhuang
2011-12-22 14:38 ` Mark Brown
2011-12-23 14:42 ` Haojian Zhuang
-- strict thread matches above, loose matches on Subject: below --
2012-01-04 7:12 Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111222134415.GU4546@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).