From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver
Date: Wed, 28 Dec 2011 11:42:37 +0000 [thread overview]
Message-ID: <20111228114237.GF24405@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111228033128.GM15863@b20223-02.ap.freescale.net>
On Wed, Dec 28, 2011 at 11:31:29AM +0800, Richard Zhao wrote:
> On Wed, Dec 28, 2011 at 11:14:10AM +0800, Richard Zhao wrote:
> > > + if (cpu_reg) {
> > > + ret = regulator_is_supported_voltage(cpu_reg,
> > > + cpu_volts[i * 2], cpu_volts[i * 2 + 1]);
> > Is there any reason you didn't export symbol regulator_is_supported_voltage?
> > and also it don't have !REGULATOR dummy implementation.
> regulator_set_voltage_time and some other functions don't have dummy one
> either.
You can't usefully work with voltages without knowing what the actual
voltages are - the only sensible stubs we could provide would return
errors but then any driver using the stubs would probably fail to do
whatever it was doing. With enable and disable we can sensibly stub
things out with an always on regulator.
next prev parent reply other threads:[~2011-12-28 11:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 8:24 [PATCH V5 0/7] add a generic cpufreq driver Richard Zhao
2011-12-27 8:24 ` [PATCH V5 1/7] ARM: add cpufreq transiton notifier to adjust loops_per_jiffy for smp Richard Zhao
2011-12-27 8:24 ` [PATCH V5 2/7] arm/imx: cpufreq: remove loops_per_jiffy recalculate " Richard Zhao
2011-12-27 8:24 ` [PATCH V5 3/7] cpufreq: OMAP: " Richard Zhao
2011-12-27 8:24 ` [PATCH V5 4/7] cpufreq: add clk-reg cpufreq driver Richard Zhao
2011-12-27 15:05 ` Shawn Guo
2011-12-28 1:24 ` Richard Zhao
2011-12-28 2:01 ` Shawn Guo
2011-12-28 3:31 ` Shawn Guo
2011-12-28 3:14 ` Richard Zhao
2011-12-28 3:31 ` Richard Zhao
2011-12-28 11:42 ` Mark Brown [this message]
2011-12-28 12:05 ` Richard Zhao
2011-12-28 12:14 ` Mark Brown
2011-12-28 12:40 ` Richard Zhao
2011-12-28 12:47 ` Mark Brown
2011-12-28 13:06 ` Shawn Guo
2011-12-28 12:54 ` Mark Brown
2011-12-28 13:10 ` Shawn Guo
2011-12-29 6:21 ` Richard Zhao
2011-12-29 7:23 ` Shawn Guo
2011-12-27 8:24 ` [PATCH V5 5/7] dts/imx6q: add cpufreq property Richard Zhao
2011-12-27 8:24 ` [PATCH V5 6/7] arm/imx6q: register arm_clk as cpu to clkdev Richard Zhao
2011-12-27 8:24 ` [PATCH V5 7/7] arm/imx6q: select ARCH_HAS_CPUFREQ Richard Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111228114237.GF24405@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).