From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD/GPMI : select more modules for GPMI by default
Date: Sat, 31 Dec 2011 08:01:38 +0100 [thread overview]
Message-ID: <201112310801.39019.marek.vasut@gmail.com> (raw)
In-Reply-To: <4EFEA210.30606@freescale.com>
> ? 2011?12?31? 13:44, Shawn Guo ??:
> > On Fri, Dec 30, 2011 at 12:45:37PM +0800, Huang Shijie wrote:
> >> The gpmi-nand driver needs the mxs-dma driver. So select the
> >> MXS_DMA by default. So does the MTD_CHAR.
> >>
> >> Signed-off-by: Huang Shijie<b32955@freescale.com>
> >> ---
> >>
> >> drivers/mtd/nand/Kconfig | 2 ++
> >> 1 files changed, 2 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> >> index 07c4774..1b14a3a 100644
> >> --- a/drivers/mtd/nand/Kconfig
> >> +++ b/drivers/mtd/nand/Kconfig
> >> @@ -420,6 +420,8 @@ config MTD_NAND_NANDSIM
> >>
> >> config MTD_NAND_GPMI_NAND
> >>
> >> bool "GPMI NAND Flash Controller driver"
> >> depends on MTD_NAND&& (SOC_IMX23 || SOC_IMX28)
> >>
> >> + select MXS_DMA
> >
> > We should probably have it depend on MXS_DMA rather than select it.
>
> IMHO, I think `select` is better. :)
> The MXS_DMA not only service for NAND, but SD card, etc.
> In logic, the GPMI does not depends on MXS_DMA, the GPMI may use SDMA
> too(just in logically).
And does it use that ? Technically, it's still dependent on MXS_DMA, right ?
Also, why select mtd_char, it's totally unrelated.
M
>
>
> Best Regards
> Huang Shijie
>
> > Regards,
> > Shawn
> >
> >> + select MTD_CHAR
> >>
> >> select MTD_PARTITIONS
> >> select MTD_CMDLINE_PARTS
> >>
> >> help
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2011-12-31 7:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 4:45 [PATCH] MTD/GPMI : select more modules for GPMI by default Huang Shijie
2011-12-31 5:44 ` Shawn Guo
2011-12-31 5:48 ` Huang Shijie
2011-12-31 7:01 ` Marek Vasut [this message]
2011-12-31 7:10 ` Huang Shijie
2011-12-31 7:24 ` Shawn Guo
2011-12-31 7:27 ` Huang Shijie
2011-12-31 15:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112310801.39019.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).