From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] regulator/fixed: set constraints.apply_uV to 0
Date: Sat, 31 Dec 2011 21:59:28 +0000 [thread overview]
Message-ID: <20111231215925.GA12740@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20111231012629.GF2414@b20223-02.ap.freescale.net>
On Sat, Dec 31, 2011 at 09:26:30AM +0800, Richard Zhao wrote:
> On Sat, Dec 31, 2011 at 01:02:40AM +0000, Mark Brown wrote:
> > > > It shouldn't actually be passing on the constraint setting the voltage
> > > > when it constructs the constraints.
> The below code is where fixed regulator construct the constraints.
It's not code which is specific to the fixed regulator, it's generic
code that's used by all regulators.
> > > - /* Only one voltage? Then make sure it's set. */
> > > - if (constraints->min_uV == constraints->max_uV)
> > > - constraints->apply_uV = true;
> > No! That's going to break *all* other users.
> The above code follows your idea. why you still say no?
You're just randomly inserting code for a specific driver into the
generic regulator API with no consideration for the effect on other
users.
> Could you please past some code to show your suggested solution,
> or you send out a patch to fix it?
Not in the immediate future.
next prev parent reply other threads:[~2011-12-31 21:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 6:06 [PATCH 1/1] regulator/fixed: set constraints.apply_uV to 0 Richard Zhao
2011-12-30 10:30 ` Mark Brown
2011-12-30 10:38 ` Richard Zhao
2011-12-30 10:48 ` Mark Brown
2011-12-30 11:08 ` Richard Zhao
2011-12-31 1:02 ` Mark Brown
2011-12-31 1:26 ` Richard Zhao
2011-12-31 21:59 ` Mark Brown [this message]
2012-01-02 13:46 ` Richard Zhao
2012-01-02 14:39 ` Mark Brown
2012-01-04 2:47 ` Richard Zhao
2011-12-31 12:51 ` [PATCH 1/1] regulator/fixed: pass regulator_register of_node Richard Zhao
2012-01-02 12:46 ` Mark Brown
2012-01-02 13:22 ` Richard Zhao
2012-01-04 3:07 ` [PATCH v2 1/1] regulator: set constraints.apply_uV to 0 in of_get_fixed_voltage_config Richard Zhao
2012-01-06 9:51 ` Richard Zhao
2012-01-06 18:43 ` Mark Brown
2012-01-06 19:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111231215925.GA12740@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).