linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support
Date: Mon, 2 Jan 2012 00:34:30 -0700	[thread overview]
Message-ID: <20120102073430.GH13015@ponder.secretlab.ca> (raw)
In-Reply-To: <1325483675-21908-1-git-send-email-thomas.abraham@linaro.org>

On Mon, Jan 02, 2012 at 11:24:31AM +0530, Thomas Abraham wrote:
> The platform-lcd driver depends on platform-specific callbacks to setup the
> lcd panel. These callbacks are supplied using driver's platform data. But
> for adding device tree support for platform-lcd driver, providing such
> callbacks is not possible (without using auxdata).
> 
> Since the callbacks are usually lcd panel specific, it is possible to include
> the lcd panel specific setup and control functionality in the platform-lcd
> driver itself, thereby eliminating the need for supplying platform specific
> callbacks to the driver. The platform-lcd driver can include support for
> multiple lcd panels.
> 
> This patchset removes the need for platform data for platform-lcd driver and
> adds support which can be used to implement lcd panel specific functionality
> in the driver. As an example, the support for Hydis hv070wsa lcd panel is added
> to the platform-lcd driver which is then used on the Exynos4 based Origen board.
> This currently breaks build for other users of platform-lcd driver. Those can be
> fixed if this approach is acceptable.

Approach looks okay to me.  I've not looked too deeply though.

g.

> 
> Thomas Abraham (4):
>   lcd: platform-lcd: Eliminate need for platform data
>   lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel
>   ARM: Exynos: Remove platform data of platform-lcd driver
>   lcd: platform-lcd: Add device tree support
> 
>  arch/arm/mach-exynos/mach-origen.c     |   25 +-----
>  drivers/video/backlight/Kconfig        |    6 ++
>  drivers/video/backlight/platform_lcd.c |  128 ++++++++++++++++++++++++++++---
>  include/video/platform_lcd.h           |   11 +--
>  4 files changed, 129 insertions(+), 41 deletions(-)
> 

  parent reply	other threads:[~2012-01-02  7:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-02  5:54 [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support Thomas Abraham
2012-01-02  5:54 ` [RFC][PATCH 1/4] lcd: platform-lcd: Eliminate need for platform data Thomas Abraham
2012-01-02  5:54   ` [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel Thomas Abraham
2012-01-02  5:54     ` [RFC][PATCH 3/4] ARM: Exynos: Remove platform data of platform-lcd driver Thomas Abraham
2012-01-02  5:54       ` [RFC][PATCH 4/4] lcd: platform-lcd: Add device tree support Thomas Abraham
2012-01-02  7:34         ` Grant Likely
2012-01-02 17:33           ` Thomas Abraham
2012-01-02  8:02     ` [RFC][PATCH 2/4] lcd: platform-lcd: Add support for Hydis hv070wsa lcd panel Kyungmin Park
2012-01-02 17:39       ` Thomas Abraham
2012-01-02 11:45     ` Mark Brown
2012-01-02 17:41       ` Thomas Abraham
2012-01-02 11:59   ` [RFC][PATCH 1/4] lcd: platform-lcd: Eliminate need for platform data Mark Brown
2012-01-02 17:51     ` Thomas Abraham
2012-01-02 18:13       ` Mark Brown
2012-01-03  8:26         ` Thomas Abraham
2012-01-02  6:48 ` [RFC][PATCH 0/4] lcd: platform-lcd: Add lcd panel and device tree support Olof Johansson
2012-01-02 17:31   ` Thomas Abraham
2012-01-02  7:34 ` Grant Likely [this message]
2012-01-03  9:06 ` Lars-Peter Clausen
2012-01-03 11:54   ` Thomas Abraham
2012-01-03 12:26     ` Lars-Peter Clausen
2012-01-03 17:07       ` Thomas Abraham
2012-01-03 18:36         ` Lars-Peter Clausen
2012-01-04  6:13           ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120102073430.GH13015@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).