From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Tue, 3 Jan 2012 11:20:04 +0000 Subject: [PATCH 09/12] ARM: EXYNOS: introduce arch/arm/mach-exynos/common.[ch] In-Reply-To: <012801ccca07$037a24a0$0a6e6de0$%kim@samsung.com> References: <1324385316-6052-1-git-send-email-kgene.kim@samsung.com> <1324385316-6052-10-git-send-email-kgene.kim@samsung.com> <20111223191935.GS2577@n2100.arm.linux.org.uk> <088101ccc1d8$d2023b00$7606b100$%kim@samsung.com> <08f401ccc469$9a93a800$cfbaf800$%kim@samsung.com> <20120103104120.GK2914@n2100.arm.linux.org.uk> <012601ccca05$57d732b0$07859810$%kim@samsung.com> <20120103105425.GL2914@n2100.arm.linux.org.uk> <012801ccca07$037a24a0$0a6e6de0$%kim@samsung.com> Message-ID: <20120103112003.GN2914@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jan 03, 2012 at 08:01:15PM +0900, Kukjin Kim wrote: > If any problems, please kindly let me know. Right, this looks better. I'm now left with one remaining bit: arch/arm/mach-exynos/include/mach/system.h:#include arch/arm/plat-s3c24xx/cpu.c:#include arch/arm/mach-s3c64xx/include/mach/system.h:#include arch/arm/mach-s3c2410/include/mach/system.h:#include and: arch/arm/plat-samsung/include/plat/system-reset.h: ... #include static void arch_reset(char mode, const char *cmd) { arch_wdt_reset(); } I assume that with all the patches I now have merged, arch_reset() should never be called on any Samsung platform, and so the include of plat/watchdog-reset.h and call of arch_wdt_reset() can be removed in my "ARM: restart: plat-samsung: remove plat/reset.h and s5p_reset_hook" patch? What about arch/arm/plat-s3c24xx/cpu.c's include of system-reset.h? Does that need to be replaced with watchdog-reset.h? That then leads to "ARM: restart: remove the now empty arch_reset()" removing system-reset.h and all includes of that file?