From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: setup.c: Fix build warning by removing unneeded header file
Date: Tue, 3 Jan 2012 15:42:18 +0000 [thread overview]
Message-ID: <20120103154218.GW2914@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1325536725-28403-1-git-send-email-festevam@gmail.com>
On Mon, Jan 02, 2012 at 06:38:45PM -0200, Fabio Estevam wrote:
> Fix the following build warning:
>
> CC arch/arm/kernel/setup.o
> In file included from arch/arm/kernel/setup.c:39:
> arch/arm/include/asm/elf.h:102:1: warning: "vmcore_elf64_check_arch" redefined
> In file included from arch/arm/kernel/setup.c:24:
> include/linux/crash_dump.h:30:1: warning: this is the location of the previous definition
>
> Since commit 93a72052 (crash_dump: export is_kdump_kernel to modules, consolidate elfcorehdr_addr, setup_elfcorehdr and saved_max_pfn)
> the inclusion of <linux/crash_dump.h> is no longer needed.
>
> Remove the inclusion of <linux/crash_dump.h> and the build warning is fixed.
Actually, this is fragile. This is _excessively_ fragile.
linux/crash_dump.h makes no attempt to include asm/elf.h, but it depends
on stuff in asm/elf.h to determine how stuff inside this file is defined
at parse time.
So, if asm/elf.h is included after linux/crash_dump.h or not at all, you
get a different result from the situation where asm/elf.h is included
before.
Therefore, while this change may on the face of it seem correct, it's
only a sticky plaster over the problem by avoiding the situation rather
than fixing it properly.
I won't apply this until the real problem (missing include in
linux/crash_dump.h) is resolved.
next prev parent reply other threads:[~2012-01-03 15:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 20:11 [PATCH] ARM: setup.c: Change the order of include files to avoid build warning Fabio Estevam
2012-01-02 20:38 ` [PATCH v2] ARM: setup.c: Fix build warning by removing unneeded header file Fabio Estevam
2012-01-03 15:42 ` Russell King - ARM Linux [this message]
2012-01-13 15:40 ` Fabio Estevam
2012-01-13 15:46 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120103154218.GW2914@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).