From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: prom.h: Fix build error by removing unneeded header file
Date: Wed, 4 Jan 2012 09:14:58 +0000 [thread overview]
Message-ID: <20120104091458.GH2914@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120104080731.GD15503@ponder.secretlab.ca>
On Wed, Jan 04, 2012 at 01:07:31AM -0700, Grant Likely wrote:
> On Mon, Jan 02, 2012 at 02:19:03PM -0200, Fabio Estevam wrote:
> > Fix the following build error:
> >
> > CC [M] fs/udf/balloc.o
> > In file included from /home/fabio/next/linux-next/arch/arm/include/asm/prom.h:16,
> > from include/linux/of.h:140,
> > from include/asm-generic/gpio.h:7,
> > from arch/arm/plat-mxc/include/mach/irqs.h:14,
> > from /home/fabio/next/linux-next/arch/arm/include/asm/irq.h:4,
> > from /home/fabio/next/linux-next/arch/arm/include/asm/hardirq.h:6,
> > from include/linux/hardirq.h:7,
> > from include/linux/highmem.h:8,
> > from include/linux/pagemap.h:10,
> > from include/linux/buffer_head.h:13,
> > from fs/udf/udfdecl.h:11,
> > from fs/udf/balloc.c:22:
> > /home/fabio/next/linux-next/arch/arm/include/asm/setup.h:146: error: redefinition of 'struct tag'
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Well that's ugly. There are two definitions of struct tag. The patch
> does fix the compile error, but it could easily reoccur. Ideally one
> of the structures should be renamed.
I'm not renaming the ARM one as it's an API thing which gets shared with
boot loaders. Changing that is likely to cause breakage outside the
kernel tree.
prev parent reply other threads:[~2012-01-04 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 16:19 [PATCH] ARM: prom.h: Fix build error by removing unneeded header file Fabio Estevam
2012-01-04 8:07 ` Grant Likely
2012-01-04 9:14 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104091458.GH2914@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).