linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: dt: tegra30.dtsi: Reformat gpio's interrupts property
Date: Wed, 4 Jan 2012 12:50:27 -0700	[thread overview]
Message-ID: <20120104195027.GE15503@ponder.secretlab.ca> (raw)
In-Reply-To: <1325702378-20863-3-git-send-email-swarren@nvidia.com>

On Wed, Jan 04, 2012 at 11:39:35AM -0700, Stephen Warren wrote:
> The new content matches tegra20.dtsi, and is < 80 columns.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
>  arch/arm/boot/dts/tegra30.dtsi |    8 +++++++-
>  1 files changed, 7 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
> index ee7db98..e5d1406 100644
> --- a/arch/arm/boot/dts/tegra30.dtsi
> +++ b/arch/arm/boot/dts/tegra30.dtsi
> @@ -55,7 +55,13 @@
>  	gpio: gpio at 6000d000 {
>  		compatible = "nvidia,tegra30-gpio", "nvidia,tegra20-gpio";
>  		reg = < 0x6000d000 0x1000 >;
> -		interrupts = < 0 32 0x04 0 33 0x04 0 34 0x04 0 35 0x04 0 55 0x04 0 87 0x04 0 89 0x04 >;
> +		interrupts = < 0 32 0x04
> +			       0 33 0x04
> +			       0 34 0x04
> +			       0 35 0x04
> +			       0 55 0x04
> +			       0 87 0x04
> +			       0 89 0x04 >;

Nit: I often find the following form convenient (even if it doesn't change the data generation):

		interrupts = < 0 32 0x04 >,
			     < 0 33 0x04 >,
			     < 0 34 0x04 >,
			     < 0 35 0x04 >,
			     < 0 55 0x04 >,
			     < 0 87 0x04 >,
			     < 0 89 0x04 >;

Otherwise:

Acked-by: Grant Likely <grant.likely@secretlab.ca>

>  		#gpio-cells = <2>;
>  		gpio-controller;
>  	};
> -- 
> 1.7.0.4
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2012-01-04 19:50 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 18:39 [PATCH 1/6] ARM: tegra: Remove use of TEGRA_GPIO_TO_IRQ Stephen Warren
2012-01-04 18:39 ` [PATCH 2/6] dt: tegra gpio: Flesh out binding documentation Stephen Warren
2012-01-04 18:39 ` [PATCH 3/6] ARM: dt: tegra30.dtsi: Reformat gpio's interrupts property Stephen Warren
2012-01-04 19:50   ` Grant Likely [this message]
2012-01-04 18:39 ` [PATCH 4/6] ARM: dt: tegra30.dtsi: Add extra GPIO interrupt Stephen Warren
2012-01-04 18:39 ` [PATCH 5/6] gpio: tegra: Dynamically allocate IRQ base, and support DT Stephen Warren
2012-01-05  7:23   ` Thierry Reding
2012-01-05 17:47     ` Stephen Warren
2012-01-05 17:56       ` Grant Likely
2012-01-05 13:17   ` Jamie Iles
2012-01-05 16:47     ` Stephen Warren
2012-01-05 16:48       ` Jamie Iles
2012-01-04 18:39 ` [PATCH 6/6] gpio: tegra: Parameterize the number of banks Stephen Warren
2012-01-04 19:54   ` Rob Herring
2012-01-04 20:00     ` Stephen Warren
2012-01-04 22:00       ` Grant Likely
2012-01-05 17:24         ` Rob Herring
2012-01-13 20:55           ` Stephen Warren
2012-01-14 15:15             ` Rob Herring
2012-01-04 19:52 ` [PATCH 1/6] ARM: tegra: Remove use of TEGRA_GPIO_TO_IRQ Grant Likely
2012-01-24  8:34   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104195027.GE15503@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).