From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/6] ARM: at91/gpio: add DT support
Date: Wed, 4 Jan 2012 22:04:32 +0000 [thread overview]
Message-ID: <20120104220432.GJ11810@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1325615688-16860-1-git-send-email-nicolas.ferre@atmel.com>
On Tue, Jan 03, 2012 at 07:34:48PM +0100, Nicolas Ferre wrote:
> + at91_gpio->clock = clk_get_sys(NULL, at91_gpio->chip.label);
> + if (!at91_gpio->clock) {
> + pr_err("at91_gpio.%d, failed to get clock, ignoring.\n",
> + alias_id);
> + goto ioremap_err;
> + }
> +
> + /* enable PIO controller's clock */
> + if(clk_enable(at91_gpio->clock)) {
> + pr_err("at91_gpio.%d, failed to enable clock, ignoring.\n",
> + alias_id);
> + goto clk_err;
> + }
No new code should be added to the kernel which uses clk_enable() without
using clk_prepare() first. Ditto clk_disable() and clk_unprepare().
> + at91_gpio->clock = clk_get_sys(NULL, at91_gpio->chip.label);
> + if (!at91_gpio->clock) {
> + pr_err("at91_gpio.%d, failed to get clock, ignoring.\n", i);
> + goto ioremap_err;
> + }
> +
> + if(clk_enable(at91_gpio->clock)) {
> + pr_err("at91_gpio.%d, failed to enable clock, ignoring.\n", i);
> + goto clk_err;
> + }
I've seen this code somewhere before... Couldn't this be separated out into
a helper function?
next prev parent reply other threads:[~2012-01-04 22:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-15 19:16 [PATCH 0/6] ARM: at91: irqdomain and device tree for AIC and GPIO Nicolas Ferre
2011-12-15 19:16 ` [PATCH v4 1/6] ARM: at91/aic: add irq domain and device tree support Nicolas Ferre
2012-01-04 19:40 ` Grant Likely
2012-01-05 16:26 ` Nicolas Ferre
2012-01-05 18:02 ` Grant Likely
2011-12-15 19:16 ` [PATCH 2/6] ARM: at91/gpio: add irqdomain to gpio interrupts Nicolas Ferre
2012-01-04 19:42 ` Grant Likely
2011-12-15 19:16 ` [PATCH 3/6] ARM: at91/gpio: add DT support Nicolas Ferre
2011-12-16 10:11 ` Jamie Iles
2012-01-03 16:25 ` Nicolas Ferre
2012-01-03 18:34 ` [PATCH v2 " Nicolas Ferre
2012-01-04 19:45 ` Grant Likely
2012-01-04 22:04 ` Russell King - ARM Linux [this message]
2012-01-05 19:42 ` [PATCH v3 " Nicolas Ferre
2012-01-05 17:50 ` Nicolas Ferre
2012-01-05 20:03 ` [PATCH v4 " Nicolas Ferre
2011-12-15 19:16 ` [PATCH 4/6] ARM: at91/gpio: add .to_irq gpio_chip handler and rework irq_to_gpio Nicolas Ferre
2012-01-04 19:47 ` Grant Likely
2011-12-15 19:16 ` [PATCH 5/6] ARM: at91/gpio: remove the static specification of gpio_chip.base Nicolas Ferre
2012-01-04 19:47 ` Grant Likely
2011-12-15 19:16 ` [PATCH 6/6] ARM: at91/board-dt: remove AIC irq domain from board file Nicolas Ferre
2012-01-04 19:48 ` Grant Likely
2011-12-16 1:53 ` [PATCH 0/6] ARM: at91: irqdomain and device tree for AIC and GPIO Rob Herring
2011-12-16 16:29 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120104220432.GJ11810@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).