From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 2/2] ARM: imx: Add mx5 cpuidle implmentation
Date: Thu, 5 Jan 2012 05:55:09 +0000 [thread overview]
Message-ID: <20120105055508.GD11867@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAMXH7KEHsighKYkPhhgHmE9s7sxtP4hz8L+Z+LMsrD14kiqJJQ@mail.gmail.com>
On Wed, Jan 04, 2012 at 05:35:39PM -0600, Rob Lee wrote:
> On 22 December 2011 11:50, Mark Brown
> > On Wed, Dec 14, 2011 at 01:02:06AM -0600, Robert Lee wrote:
> >> + ? ? clk_enable(&gpc_dvfs_clk);
> > Should these enables be in the cpuidle code? ?The device appears to have
> > been working fine without them thus far... ?Alternatively, if they
> > should be on anyway does this need to be split out and sent as a bug
> > fix?
> This clock is used by the existing pm_suspend code for i.MX51 and
> other future code being worked on. Since it uses extremely minimal
> power and is required to be enabled during low power modes, it seemed
> cleanest to just enable it during clock init. But I forgot to remove
> it from it's enabling from i.MX51 pm_suspend code so I can do that for
> v3.
Sounds like it's worth splitting out and getting it merged as quickly as
possible then? It wasn't the code I was querying, it was the way it is
being merged.
next prev parent reply other threads:[~2012-01-05 5:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 7:02 [RFC PATCH v2 0/2] Add common cpuidle code for consolidation Robert Lee
2011-12-14 7:02 ` [RFC PATCH v2 1/2] cpuidle: Add common init interface and idle functionality Robert Lee
2011-12-22 18:09 ` Mark Brown
2012-01-04 23:21 ` Rob Lee
2011-12-22 22:57 ` Rob Herring
2012-01-04 23:15 ` Rob Lee
2012-01-04 23:35 ` Turquette, Mike
2012-01-04 23:51 ` Rob Herring
2012-01-05 20:11 ` Turquette, Mike
2012-01-05 9:32 ` Russell King - ARM Linux
2012-01-05 16:42 ` Rob Lee
2011-12-14 7:02 ` [RFC PATCH v2 2/2] ARM: imx: Add mx5 cpuidle implmentation Robert Lee
2011-12-22 17:50 ` Mark Brown
2012-01-04 23:35 ` Rob Lee
2012-01-05 3:21 ` Shawn Guo
2012-01-05 5:55 ` Mark Brown [this message]
2012-01-06 21:10 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105055508.GD11867@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).