From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: proc-v7: remove harvard cache stuff
Date: Thu, 5 Jan 2012 09:48:58 +0000 [thread overview]
Message-ID: <20120105094857.GA21121@arm.com> (raw)
In-Reply-To: <1325745462-6560-1-git-send-email-shawn.guo@linaro.org>
On Thu, Jan 05, 2012 at 06:37:42AM +0000, Shawn Guo wrote:
> The harvard cache related comment and code in proc-v7.S were copied
> from proc-v6.S by mistake, so let's remove them.
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> arch/arm/mm/proc-v7.S | 7 -------
> 1 files changed, 0 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mm/proc-v7.S b/arch/arm/mm/proc-v7.S
> index e70a737..59a4077 100644
> --- a/arch/arm/mm/proc-v7.S
> +++ b/arch/arm/mm/proc-v7.S
> @@ -271,10 +271,6 @@ ENDPROC(cpu_v7_do_resume)
> * Initialise TLB, Caches, and MMU state ready to switch the MMU
> * on. Return in r0 the new CP15 C1 control register setting.
> *
> - * We automatically detect if we have a Harvard cache, and use the
> - * Harvard cache control instructions insead of the unified cache
> - * control instructions.
> - *
> * This should be able to cover all ARMv7 cores.
> *
> * It is assumed that:
> @@ -373,9 +369,6 @@ __v7_setup:
> #endif
>
> 3: mov r10, #0
> -#ifdef HARVARD_CACHE
> - mcr p15, 0, r10, c7, c5, 0 @ I+BTB cache invalidate
> -#endif
I thought we still need to invalidate the I-cache, maybe moving it
higher up after the v7_flush_dcache_all call.
--
Catalin
next prev parent reply other threads:[~2012-01-05 9:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 9:26 [PATCH] ARM: imx6: fix v7_invalidate_l1 by adding I-Cache invalidation Shawn Guo
2011-12-30 10:47 ` Jason Liu
2011-12-31 9:21 ` Shawn Guo
2012-01-03 17:41 ` Russell King - ARM Linux
2012-01-03 17:28 ` Russell King - ARM Linux
2012-01-03 17:58 ` Catalin Marinas
2012-01-05 6:37 ` [PATCH] ARM: proc-v7: remove harvard cache stuff Shawn Guo
2012-01-05 6:42 ` Kyungmin Park
2012-01-05 9:48 ` Catalin Marinas [this message]
2012-01-17 14:18 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120105094857.GA21121@arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).