linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mxs: detect SoC by checking CHIPID register
Date: Fri, 6 Jan 2012 14:43:02 +0100	[thread overview]
Message-ID: <20120106134302.GC2610@pengutronix.de> (raw)
In-Reply-To: <20120106133908.GD4790@S2101-09.ap.freescale.net>


> > 0x310 should not be hardcoded. CHIPID could be MXS_CHIPID.
> > 
> I thought about those when I wrote the code, and decided not to bother,
> since they are very really limited in mxs.h.  But now I think I should
> bother, because your comments are here.

:) I think 0x310 should be defined in digctl.h (which was introduced by
Aisheng IIRC). Then, we at least know which functionality from DIGCTL is
used currently.

> > Can't we use the cpu_is-functions here?
> > 
> No.  We are running with MMU off here.

Right, thanks, missed that.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120106/c17eb839/attachment.sig>

  reply	other threads:[~2012-01-06 13:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06  2:41 [PATCH 0/2] ARM: mxs: use CHIPID hardware to detect SoC Shawn Guo
2012-01-06  2:41 ` [PATCH 1/2] ARM: mxs: detect SoC by checking CHIPID register Shawn Guo
2012-01-06 11:40   ` Wolfram Sang
2012-01-06 13:39     ` Shawn Guo
2012-01-06 13:43       ` Wolfram Sang [this message]
2012-01-06  2:41 ` [PATCH 2/2] ARM: mxs: Add initial support for Bluegiga APX4 Development Kit Shawn Guo
2012-01-06 11:26 ` [PATCH 0/2] ARM: mxs: use CHIPID hardware to detect SoC Lauri Hintsala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120106134302.GC2610@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).