linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sshtylyov@ru.mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DaVinci: can only power up domains on DM644x
Date: Fri, 6 Jan 2012 21:40:33 +0300	[thread overview]
Message-ID: <201201062140.33712.sshtylyov@ru.mvista.com> (raw)
In-Reply-To: <201109151829.49256.sshtylyov@ru.mvista.com>

Only DM644x has the domain power up procedure documented; for all other SoCs a
bootloader probably should have powered the domain up. Print error message and
give up if it hasn't done so.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
Sekhar, I haven't forgotten about that patch we discussed, just lacked time...

 arch/arm/mach-davinci/psc.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Index: linux-davinci/arch/arm/mach-davinci/psc.c
===================================================================
--- linux-davinci.orig/arch/arm/mach-davinci/psc.c
+++ linux-davinci/arch/arm/mach-davinci/psc.c
@@ -81,6 +81,14 @@ void davinci_psc_config(unsigned int dom
 
 	pdstat = __raw_readl(psc_base + PDSTAT + 4 * domain);
 	if ((pdstat & PDSTAT_STATE_MASK) == 0) {
+		/* Only DM644x has the domain power up procedure documented. */
+		if (!cpu_is_davinci_dm644x()) {
+			pr_err("Don't know how to power on domain %u of PSC%u, "
+			       "probably bootloader should have done this!",
+			       domain, ctlr);
+			BUG();
+		}
+
 		pdctl = __raw_readl(psc_base + PDCTL + 4 * domain);
 		pdctl |= PDCTL_NEXT;
 		__raw_writel(pdctl, psc_base + PDCTL + 4 * domain);

  parent reply	other threads:[~2012-01-06 18:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15 14:29 [PATCH] DaVinci: only poll EPCPR on DM644x and DM355 Sergei Shtylyov
2011-09-15 19:27 ` Karicheri, Muralidharan
2011-10-23 11:10 ` Nori, Sekhar
2011-10-23 12:43   ` Sergei Shtylyov
2011-10-23 16:18     ` Nori, Sekhar
2011-10-28 20:44       ` Sergei Shtylyov
2012-01-06 18:40 ` Sergei Shtylyov [this message]
2012-01-06 18:48   ` [PATCH v2] DaVinci: can only power up domains on DM644x Sergei Shtylyov
2012-01-12 12:00     ` Karicheri, Muralidharan
2012-01-17 19:56       ` Nori, Sekhar
2012-01-20 18:45       ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201201062140.33712.sshtylyov@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).