From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91: fix at91rm9200 soc subtype handling
Date: Sat, 7 Jan 2012 12:20:23 +0100 [thread overview]
Message-ID: <20120107112023.GD2854@game.jcrosoft.org> (raw)
In-Reply-To: <4F02C900.6090907@atmel.com>
On 10:23 Tue 03 Jan , Nicolas Ferre wrote:
> On 01/02/2012 03:21 PM, Nicolas Ferre :
> > On 12/28/2011 12:10 PM, Veli-Pekka Peltola :
> >> BGA should be the default SoC subtype but it is set to unknown if
> >> not explicitly set to PQFP. Currently setting it to PQFP sets subtype
> >> to BGA as subtypes are swapped in at91rm9200_set_type().
> >>
> >> Wrong subtype causes GPIO bank D not to work at all.
> >>
> >> After this fix BGA subtype is set as default. On boot BGA is printed
> >> always but it is set to PQFP if requested before setting amount of GPIO
> >> banks.
> >>
> >> Signed-off-by: Veli-Pekka Peltola <veli-pekka.peltola@bluegiga.com>
> >
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> >
> > I will queue it in a "fixes" branch (hopefully for 3.3).
>
> I come back to this:
> 1/ There is definitively a bug in at91rm9200_set_type()
> 2/ I do not know if it is a good idea to set BGA subtype by default. I
> would simply keep the "unknown" subtype printed out until the real
> subtype is set by the "*_init_early()" of the board code.
>
> So, I may modify your original patch and submit it for discussion...
> Jean-Christophe, I would like to have your opinion on this.
agreed
Best Regards,
J.
next prev parent reply other threads:[~2012-01-07 11:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 11:10 [PATCH] at91: fix at91rm9200 soc subtype handling Veli-Pekka Peltola
2012-01-02 14:21 ` Nicolas Ferre
2012-01-03 9:23 ` Nicolas Ferre
2012-01-03 11:38 ` [PATCH v2] ARM: " Nicolas Ferre
2012-01-07 11:21 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-07 11:20 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2012-01-07 11:19 ` [PATCH] " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120107112023.GD2854@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).