From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] dma: imx-dma: start transfer in issue_pending
Date: Mon, 9 Jan 2012 10:51:06 +0000 [thread overview]
Message-ID: <20120109105106.GI21765@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1326101570-3716-4-git-send-email-s.hauer@pengutronix.de>
On Mon, Jan 09, 2012 at 10:32:49AM +0100, Sascha Hauer wrote:
> The DMA API requires that transfers are started in issue_pending
DMA engine API != DMA API.
> instead of tx_submit. Fix this.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/dma/imx-dma.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/dma/imx-dma.c b/drivers/dma/imx-dma.c
> index 4be55f9..217207b 100644
> --- a/drivers/dma/imx-dma.c
> +++ b/drivers/dma/imx-dma.c
> @@ -186,8 +186,6 @@ static dma_cookie_t imxdma_tx_submit(struct dma_async_tx_descriptor *tx)
>
> cookie = imxdma_assign_cookie(imxdmac);
>
> - imx_dma_enable(imxdmac->imxdma_channel);
> -
> spin_unlock_irq(&imxdmac->lock);
>
> return cookie;
> @@ -332,9 +330,10 @@ static struct dma_async_tx_descriptor *imxdma_prep_dma_cyclic(
>
> static void imxdma_issue_pending(struct dma_chan *chan)
> {
> - /*
> - * Nothing to do. We only have a single descriptor
> - */
> + struct imxdma_channel *imxdmac = to_imxdma_chan(chan);
> +
> + if (imxdmac->status == DMA_IN_PROGRESS)
> + imx_dma_enable(imxdmac->imxdma_channel);
> }
>
> static int __init imxdma_probe(struct platform_device *pdev)
> --
> 1.7.7.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-01-09 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 9:32 [PATCH] fix starting of transfers in i.MX dma drivers Sascha Hauer
2012-01-09 9:32 ` [PATCH 1/4] mmc: mxcmmc: add missing dma_async_issue_pending Sascha Hauer
2012-01-09 9:32 ` [PATCH 2/4] ASoC: i.MX: Add " Sascha Hauer
2012-01-09 16:13 ` Mark Brown
2012-01-10 8:39 ` Sascha Hauer
2012-01-09 9:32 ` [PATCH 3/4] dma: imx-dma: start transfer in issue_pending Sascha Hauer
2012-01-09 10:51 ` Russell King - ARM Linux [this message]
2012-01-09 9:32 ` [PATCH 4/4] dma: imx-sdma: " Sascha Hauer
2012-01-12 12:25 ` [PATCH] fix starting of transfers in i.MX dma drivers javier Martin
2012-01-15 17:07 ` Koul, Vinod
2012-01-30 9:12 ` Vinod Koul
2012-01-30 12:22 ` javier Martin
2012-01-30 14:03 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120109105106.GI21765@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).