From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: mxs: enable phy-clock in the driver?
Date: Wed, 11 Jan 2012 11:59:46 +0100 [thread overview]
Message-ID: <201201111159.46678.marek.vasut@gmail.com> (raw)
In-Reply-To: <20120108144558.GB2544@pengutronix.de>
> Hi Shawn,
>
> I recently noticed that my tx28 board did not have net when booting from
> NAND (before that, barebox was setting up the network). Adding lines like
> these from mx28evk helped:
>
> 228 /* Enable fec phy clock */
> 229 clk = clk_get_sys("pll2", NULL);
> 230 if (!IS_ERR(clk))
> 231 clk_enable(clk);
>
> So, if every board seems to need this, I'd think this should rather be in
> the driver? Am I correct or is there something I have overlooked?
>
> Regards,
>
> Wolfram
Did you really disable the clock to FEC or only the PHY didn't have clock?
M
prev parent reply other threads:[~2012-01-11 10:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 14:45 mxs: enable phy-clock in the driver? Wolfram Sang
2012-01-09 1:34 ` Shawn Guo
2012-01-09 6:40 ` Lothar Waßmann
2012-01-09 6:58 ` Shawn Guo
2012-01-09 7:05 ` Lothar Waßmann
2012-01-09 7:21 ` Shawn Guo
2012-01-09 7:17 ` Lothar Waßmann
2012-01-11 10:59 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201111159.46678.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).