From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] ARM: imx: Add imx6q thermal
Date: Thu, 12 Jan 2012 10:36:18 +0100 [thread overview]
Message-ID: <20120112093618.GB5446@pengutronix.de> (raw)
In-Reply-To: <1326266285-11656-1-git-send-email-rob.lee@linaro.org>
On Wed, Jan 11, 2012 at 01:18:05AM -0600, Robert Lee wrote:
> Add thermal support for i.MX6Q. Uses recently submitted common
> cpu_cooling functionality shown here:
>
> http://www.spinics.net/lists/linux-pm/msg26500.html
>
> Have some todo items but basic implementation is done and I'd like to
> get any helpful feedback on it.
Generally shouldn't this be a regular driver?
> +
> +/* register define of anatop */
> +#define HW_ANADIG_ANA_MISC0 (0x00000150)
> +#define HW_ANADIG_ANA_MISC0_SET (0x00000154)
> +#define HW_ANADIG_ANA_MISC0_CLR (0x00000158)
> +#define HW_ANADIG_ANA_MISC0_TOG (0x0000015c)
unnecessary braces. Please remove.
> +
> +#if IMX6Q_THERMAL_DEBUG
> + pr_info("Temperature is %lu C\n", *temp);
> +#endif
Please don't add your own debug defines which then issue
messages with pr_info. Use pr_debug in the first place.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2012-01-12 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 7:18 [RFC] ARM: imx: Add imx6q thermal Robert Lee
2012-01-12 7:15 ` Dirk Behme
2012-01-12 20:47 ` Rob Lee
2012-01-12 9:36 ` Sascha Hauer [this message]
2012-01-13 0:11 ` Rob Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120112093618.GB5446@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).