linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kristoffer.ericson@gmail.com (Kristoffer Ericson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] mach-sa1100: modernize and cleanup timer code
Date: Thu, 12 Jan 2012 17:10:34 +0100	[thread overview]
Message-ID: <20120112161034.GE2645@Boggieman> (raw)
In-Reply-To: <1325672513-16725-1-git-send-email-linus.walleij@linaro.org>


Urs?kta f?rseningen, fick n?got minne kring att cpu klockningen inte fungerade korrekt
om man inte satte direkt systemklock v?rde. Var n?got som pratade med russell om 
f?r n?got ?r sedan.
Ska bara kika lite snabbt.

On Wed, Jan 04, 2012 at 11:21:53AM +0100, Linus Walleij wrote:
> This gets rid of the hairy mult/shift calculation for SA1100
> timers and relies on clockevent core to figure this out, and removes
> the hard-coded rate constant in favor of the CLOCK_TICK_RATE
> already used by the clocksource.
> 
> Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  arch/arm/mach-sa1100/time.c |   12 +++---------
>  1 files changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/mach-sa1100/time.c b/arch/arm/mach-sa1100/time.c
> index 69e3353..5cb8c7b 100644
> --- a/arch/arm/mach-sa1100/time.c
> +++ b/arch/arm/mach-sa1100/time.c
> @@ -88,20 +88,14 @@ static void __init sa1100_timer_init(void)
>  	OIER = 0;
>  	OSSR = OSSR_M0 | OSSR_M1 | OSSR_M2 | OSSR_M3;
>  
> -	setup_sched_clock(sa1100_read_sched_clock, 32, 3686400);
> -
> -	clockevents_calc_mult_shift(&ckevt_sa1100_osmr0, 3686400, 4);
> -	ckevt_sa1100_osmr0.max_delta_ns =
> -		clockevent_delta2ns(0x7fffffff, &ckevt_sa1100_osmr0);
> -	ckevt_sa1100_osmr0.min_delta_ns =
> -		clockevent_delta2ns(MIN_OSCR_DELTA * 2, &ckevt_sa1100_osmr0) + 1;
> +	setup_sched_clock(sa1100_read_sched_clock, 32, CLOCK_TICK_RATE);
>  	ckevt_sa1100_osmr0.cpumask = cpumask_of(0);
> -
>  	setup_irq(IRQ_OST0, &sa1100_timer_irq);
>  
>  	clocksource_mmio_init(&OSCR, "oscr", CLOCK_TICK_RATE, 200, 32,
>  		clocksource_mmio_readl_up);
> -	clockevents_register_device(&ckevt_sa1100_osmr0);
> +	clockevents_config_and_register(&ckevt_sa1100_osmr0, CLOCK_TICK_RATE,
> +					MIN_OSCR_DELTA * 2, 0x7fffffff);
>  }
>  
>  #ifdef CONFIG_PM
> -- 
> 1.7.6.4

  reply	other threads:[~2012-01-12 16:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-04 10:21 [PATCH 2/2] mach-sa1100: modernize and cleanup timer code Linus Walleij
2012-01-12 16:10 ` Kristoffer Ericson [this message]
2012-01-14  7:33   ` Linus Walleij
2012-01-14  8:42     ` Russell King - ARM Linux
2012-01-14 11:41       ` Linus Walleij
2012-01-14 12:09         ` Russell King - ARM Linux
2012-01-14 12:59           ` Kristoffer Ericson
2012-01-14 19:34           ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120112161034.GE2645@Boggieman \
    --to=kristoffer.ericson@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).